Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug Service Bus binder consumer cannot be automatically created Topic/Subscriptions #30722

Merged
merged 11 commits into from
Sep 2, 2022
Merged

Fix bug Service Bus binder consumer cannot be automatically created Topic/Subscriptions #30722

merged 11 commits into from
Sep 2, 2022

Conversation

hui1110
Copy link
Contributor

@hui1110 hui1110 commented Aug 31, 2022 •
edited
Loading

Description

In the current version, the Azure Service Bus binder cannot create topics/subscriptions from the consumer itself.
Fix issue: #30324

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Aug 31, 2022
@hui1110 hui1110 self-assigned this Aug 31, 2022
@hui1110 hui1110 added the azure-spring-servicebus Spring service bus related issues. label Aug 31, 2022
@hui1110 hui1110 added this to the 2022-09 milestone Aug 31, 2022
@hui1110 hui1110 linked an issue Aug 31, 2022 that may be closed by this pull request
Automatically creating Topics/Subscription with Spring Azure Binders #30324
Closed
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@hui1110 hui1110 marked this pull request as ready for review September 1, 2022 02:43
@saragluna
Copy link
Member

Please update your PR description.

@hui1110 hui1110 merged commit 8a1943e into Azure:main Sep 2, 2022
vcolin7 pushed a commit to vcolin7/azure-sdk-for-java that referenced this pull request Sep 9, 2022
@hui1110 @vcolin7
Fix bug Service Bus binder consumer cannot be automatically created T…
a093aa3 
…opic/Subscriptions (Azure#30722)
@blackr1234 blackr1234 mentioned this pull request May 6, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

Assignees

@hui1110 hui1110

Labels
azure-spring All azure-spring related issues azure-spring-servicebus Spring service bus related issues.
Projects
Spring Cloud Azure
Status: Done
Milestone
2022-09
Development

Successfully merging this pull request may close these issues.

Automatically creating Topics/Subscription with Spring Azure Binders
4 participants
@hui1110 @azure-sdk @saragluna @hui-00