-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes from master into azconfig #3055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding suppression for having named static inner classes from anonymous. * Add suppression for redundant null check. * Move SIC_INNER_SHOULD_BE_STATIC suppression * Make anonymous class in CachingKeyResolver a named inner static. * Include missing impl classes for auto-rest when it generates a variable with known null value * Suppressing unconfirmed casts because we know the cast is correct but the APIs weren't designed for it
…on 1.0.0 (Azure#2975) * Bumping up resource-manager parent pom to 1.0.0 * Bumping up eventgrid.v2019_01_01 to version 1.0.0
…java codegen (Azure#3009) * Generated from e92e525831933bedf2242fe607984757387be1b2 Add private dns module name for java codegen * Update pom for private dns * change private dns version back to beta
* Suppress using Nullable parameter as non-null for KeyVaultKey because it was a scenario in original SDK not thought of. * Suppress return empty array rather than null * Add null check for service to ensure it has been initialized * Checking for null service value before invoking method * Catching specific exceptions rather than Exception e * Use 8L so that the integer multiplication is not implicitly cast to long. * Add exclude for catch Exception in CachingKeyResolver * Catching specific exceptions rather than Exception e
- Update whitespace to match Prettier formatting - Add .prettierrc.yml - Part of Azure/azure-sdk#225
license/cla override. Check isn't coming back for some reason.
* Adding .editorconfig * Add .gitattributes * Reformat pom.client.xml * Reformat keyvault/data-plane/pom.xml * Reformat batch/data-plane/pom.xml
* Now that KeyVault data-plane has no more checkstyle errors or violations, we are now enforcing build failure for this project and all child modules. * Install build tools locally so that checkstyle can run. * Fix whitespace * It is not necessary to run checkstyle:check as the build will fail satisfactorily under the analyze job.
Record/Playback Integration in Azure Batch Java SDK tests. Added Test recordings to be used in playback mode.
conniey
added
the
Client
This issue points to a problem in the data-plane of the library.
label
Mar 7, 2019
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.