-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage code migration #3014
Storage code migration #3014
Conversation
…view-dev New storage sdk v10 preview dev
…view-dev New storage sdk v10 preview dev
…0-Preview-dev Revert "New storage sdk v10 preview dev"
…v' into New-Storage-SDK-V10-Preview-dev
Upload from non replayable flowable
10.5.0 release prep
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a direct import from the storage repo into this repo, and doesn't include any changes, cleanups, or integration into the build system - I am ok with approving this and I look forward to the cleanup PR.
@rickle-msft please look at this PR when you are back, we want to make sure that everything we have in our repo moved over here successfully. @g2vinay please wait for Rick to approve before merging |
@g2vinay Hey mate make sure to hit me up when this merges. I'll need to get the ball rolling on documentation once that happens. Do you also plan to migrate the preview branches? (if any?) |
|
Is there any reason we don't go ahead and make those changes as part of this PR as well? There seems like there is a lot of unnecessary files and stuff coming in that we could eliminate completely if we just cleaned them up at the same time. Also as I mentioned in another similar PR we have analysis tools like component governance that will start flagging stuff even if this isn't part of the build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First step looks good lets be sure to file follow-up items for the remaining clean-up work.
Includes source code as it is from Storage Java SDK master branch with history preserved.
Code location is in storage/data-plane/
In this PR, Storage SDK source code is migrated without any changes.
SDK component is not configured in the build.
No code changes on our end are included in this PR.
Follow up PR will include:
Storage SDK build integration to the central java repo.
Live tests Integration to our Azure Dev Ops pipeline.
Code + Pom cleanup