-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseline to allow providing MeterRegistry for client metrics #30065
Baseline to allow providing MeterRegistry for client metrics #30065
Conversation
…to users/fabianm/Metrics
API change check APIView has identified API level changes in this PR and created following API reviews. |
…to users/fabianm/Metrics
…to users/fabianm/Metrics
...re-cosmos/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetry.java
Outdated
Show resolved
Hide resolved
...re-cosmos/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetry.java
Outdated
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Outdated
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Outdated
Show resolved
Hide resolved
...os/src/main/java/com/azure/cosmos/implementation/clienttelemetry/ClientTelemetryMetrics.java
Show resolved
Hide resolved
...smos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/clienttelemetry/TagName.java
Outdated
Show resolved
Hide resolved
...com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdMetricsCompletionRecorder.java
Show resolved
Hide resolved
...cosmos/implementation/directconnectivity/rntbd/RntbdMetricsDelegatingCompletionRecorder.java
Show resolved
Hide resolved
...main/java/com/azure/cosmos/implementation/directconnectivity/rntbd/RntbdServiceEndpoint.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/FeedResponse.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/ClientMetricsTest.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/test/java/com/azure/cosmos/CosmosItemTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great changes, thanks 👍
…to users/fabianm/Metrics
…to users/fabianm/Metrics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @FabianMeiswinkel
I have added few comments on public surface APIs.
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosClientTelemetryConfig.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos-spark_3_2-12/src/main/scala/com/azure/cosmos/spark/CosmosConfig.scala
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/CosmosClientBuilder.java
Outdated
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosClientTelemetryConfig.java
Outdated
Show resolved
Hide resolved
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Show resolved
Hide resolved
.../azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientSideRequestStatistics.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosQueryRequestOptions.java
Show resolved
Hide resolved
sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/util/CosmosPagedFlux.java
Show resolved
Hide resolved
…to users/fabianm/Metrics
Description
This PR adds the option to emit metrics from the Azure Cosmos DB SDK via a micrometer MeterRegistry as well as doing so from the Spark connector via configuration.
Please take a look at the following to markup files with more information:
sdk/cosmos/azure-cosmos/docs/Metrics.md
sdk/cosmos/azure-cosmos-spark_3_2-12/docs/metrics.md
Perf results (point reads of <1KB docs - worst case for overhead of enabling metrics)
Perf results (point writesof <1KB docs)
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines