Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseline to allow providing MeterRegistry for client metrics #30065

Merged
merged 75 commits into from
Sep 26, 2022

Conversation

FabianMeiswinkel
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel commented Jul 21, 2022

Description

This PR adds the option to emit metrics from the Azure Cosmos DB SDK via a micrometer MeterRegistry as well as doing so from the Spark connector via configuration.

Please take a look at the following to markup files with more information:

  • sdk/cosmos/azure-cosmos/docs/Metrics.md

  • sdk/cosmos/azure-cosmos-spark_3_2-12/docs/metrics.md

Perf results (point reads of <1KB docs - worst case for overhead of enabling metrics)

Scenario 1-minute request rate per second P99.9 latency P99 latency Difference
Baseline 17,947.58 9.50 ms 3.28 ms n/a
PR without metrics 17,736.32 10.49 ms 3.69 ms -1.17 %
PR with metrics 15,513.67 8.52 ms 3.34 ms -12.53 %

Perf results (point writesof <1KB docs)

Scenario 1-minute request rate per second P99.9 latency P99 latency Difference
Baseline 9,934.08 19.01 ms 9.70 ms n/a
PR without metrics 9,873.45 13.96 ms 9.57 ms -0.61 %
PR with metrics 9,728.54 15.34 ms 9.50 ms -2.06 %

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Jul 21, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos
azure-cosmos

Copy link
Member

@xinlian12 xinlian12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great changes, thanks 👍

Copy link
Member

@kushagraThapar kushagraThapar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @FabianMeiswinkel
I have added few comments on public surface APIs.

@FabianMeiswinkel FabianMeiswinkel merged commit 6305577 into Azure:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants