Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API review comment #29710

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fix API review comment #29710

merged 1 commit into from
Jun 30, 2022

Conversation

hui1110
Copy link
Contributor

@hui1110 hui1110 commented Jun 30, 2022 •
edited
Loading

Description

As title. Fix API review comment: https://apiview.dev/Assemblies/Review/d92bff1b93344587be873098dab9f96a?diffRevisionId=faf398524cea4b7f86cff07c26b13efb&doc=False&diffOnly=False&revisionId=2f0a8d85258c407bb718fd5347e11706

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Jun 30, 2022
@hui1110 hui1110 self-assigned this Jun 30, 2022
@hui1110 hui1110 added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Jun 30, 2022
@hui1110 hui1110 added this to the 2022-07 milestone Jun 30, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-core

@hui1110 hui1110 marked this pull request as ready for review June 30, 2022 02:21
@hui1110 hui1110 merged commit a68b1eb into Azure:release/spring-cloud-azure_4.3.0 Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@jialigit jialigit Awaiting requested review from jialigit

@Netyyyy Netyyyy Awaiting requested review from Netyyyy

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@hui1110 hui1110

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
Spring Cloud Azure
Status: Done
Milestone
2022-07
Development

Successfully merging this pull request may close these issues.
3 participants
@hui1110 @azure-sdk @saragluna