Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new credential APIs in Spring Service Bus and Event Hubs and add more test cases #29484

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Use new credential APIs in Spring Service Bus and Event Hubs and add more test cases #29484

merged 4 commits into from
Jun 23, 2022

Conversation

saragluna
Copy link
Member

Description

Resolves #28931. To decouple the credential of an Event Hubs client builder from FQDN or event hub name. And add more test cases

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the azure-spring All azure-spring related issues label Jun 15, 2022
@saragluna saragluna self-assigned this Jun 15, 2022
@saragluna saragluna added this to the [2022] July milestone Jun 15, 2022
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@saragluna
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna saragluna marked this pull request as ready for review June 20, 2022 01:37
yiliuTo
yiliuTo approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saragluna saragluna merged commit 1d6a5cd into Azure:main Jun 23, 2022
@saragluna saragluna deleted the xiada/event-hub-client-builder branch June 23, 2022 08:50
kwonus-msft pushed a commit to kwonus-msft/azure-sdk-for-java-kw that referenced this pull request Jun 24, 2022
@saragluna @kwonus-msft
Use new credential APIs in Spring Service Bus and Event Hubs and add …
e2183be 
…more test cases (Azure#29484)

* use new credential APIs in Service Bus and Event Hubs and add more test cases
* fix compatibility error across spring boot versions
* add more tests
kwonus-msft added a commit that referenced this pull request Jun 27, 2022
@kwonus-msft @azure-sdk
@weidongxu-microsoft @srnagar @yiliuTo @mssfang @XiaofeiCao @samvaity @vcolin7 @kasobol-msft @FabianMeiswinkel @saragluna @JimSuplizio @soumabrata-chakraborty @Netyyyy @trande4884 @lmolkova @milismsft @benbp @weshaggard
Deltas for Convert from microseconds to milliseconds in CosmosDiagnos…
f414c17 
…tics (#29643)

* Inititial deltas: from microseconds to millisecondsI

* Fixed failed implementation that was reporting 0.0 milliseconds due to integer arithmetic

* Update changelog with PR reference.

* Updated changelog from present tense to past tense (convert ->
converted)

* Merge out from main

* Shortened the summary in changelog.

* dd formatting to changelog

* [Automation] Generate Fluent Lite from mediaservices#package-account-2021-11 (#29595)

* [Automation] Generate Fluent Lite from mediaservices#package-account-2021-11

* Update pom.xml

Co-authored-by: Weidong Xu <[email protected]>

* Increment versions for mediaservices releases (#29598)

Increment package versions for mediaservices releases

* DPG, support latest sdk automation design (#29533)

* latest codegen

* support new design of dpg sdk automation

* support EnableBatchRelease

* remove profile for coverage

* Remove coverage profile from service pom (#29572)

* Remove coverage profile from service pom

* update spring service pom

* fix build failures

* fix script that updates service pom

* resourcemanagerhybrid ci

* Support kafka of azure indentity token credentials and configuration (#29404)

* remove secondary code owner from Search (#29585)

* Mgmt network supports priority (#29503)

* codegen

* changelog for version update

* supports priority

supports priority

* session-records

* related session-records

* changelog for feature

* revapi.skip=true

* nit, remove spaces

* Update sdk/resourcemanager/azure-resourcemanager-network/src/main/java/com/azure/resourcemanager/network/models/ApplicationGatewayRequestRoutingRule.java

Co-authored-by: Weidong Xu <[email protected]>

* fix doc

* code refactor and fix javadoc

* fix javadoc

* exclude samples from code coverage report

* make exclude projects an argument of the script

* rename script parameter

Co-authored-by: Weidong Xu <[email protected]>

* Enable Form Recognizer disabled tests (#29545)

* Increment dependency versions for Key Vault and Container Registry (#29594)

* Updated dependency versions for Key Vault, Form Recognizer and Container Registry. Also updated Key Vault CHANGELOGs.

* Updated a couple more READMEs.

* Reverted version change for Form Recognizer.

* Progress reporter promoted to core and used in Http Client. (#29495)

* progress reporter.

* contexts

* comment.

* this works.

* progress handlers for http clients.

* vertx.

* fix build.

* changelogs.

* poke ci

* align naming with existing versions.

* functional interface.

* getContext.

* this might come handy.

* some PR feedback.

* remove progress handler after request./

* some feedback.

* add sendSync test.

* wip.

* contexts.

* make it final.

* changelog.

* rename this.

* sample update.

* Update sdk/core/azure-core/src/main/java/com/azure/core/util/ProgressReporter.java

Co-authored-by: Srikanta <[email protected]>

* pr feedback.

* samples in chlog.

* hide keys for now.

Co-authored-by: Srikanta <[email protected]>

* Cosmos Spark Connector: Adding .Net/C# port of the NYC-Taxi-Data sample (#29600)

* mgmt, generate desktopvirtualization with async methods in serviceClient (#29582)

* Increment versions for desktopvirtualization releases (#29610)

Increment package versions for desktopvirtualization releases

* codegen (#29612)

* Update CODEOWNERS (#29606)

* Use new credential APIs in Spring Service Bus and Event Hubs and add more test cases (#29484)

* use new credential APIs in Service Bus and Event Hubs and add more test cases
* fix compatibility error across spring boot versions
* add more tests

* [Automation] Generate Fluent Lite from extendedlocation#package-2021-08-31-preview (#29616)

* [Automation] Generate Fluent Lite from digitaltwins#package-2022-05 (#29615)

* Increment versions for orbital releases (#29614)

Increment package versions for orbital releases

* Increment versions for extendedlocation releases (#29619)

Increment package versions for extendedlocation releases

* Implement sendSync in OkHttpClient (#29601)

* simplify request body creation.

* sync okhttp client.

* test buffered responses.

* chlog.

* body's closeable.

* Prepare BOM patch release for June 2022 (#29604)

* Updated versions to latest stable releases.

* Reverted change to AOT GraalVM's POM on Form Recognizer dependency version to use the latest beta instead of the latest stable. Added a beta entry for Form Recognizer on `version_client.txt`.

* Updated BOM version in POM, README and CHANGELOG.

* Reverted `version_client.txt` and AOT GraalVM POM changes.

* Enable Batch release for metricsadvisor (#29622)

* RestProxy Always validate fluxes and inputstreams. (#29603)

* Always validate fluxes and inputstreams.

* unused.

* rebase again
remove epoll dependency from module-info (#29509)

* remove epoll dependency from module-info

Co-authored-by: annie-mac <[email protected]>
Co-authored-by: annie-mac <[email protected]>
Co-authored-by: annie-mac <[email protected]>
Co-authored-by: annie-mac <[email protected]>

* Increment package versions for digitaltwins releases (#29630)

* [ISSUE-29566] Add configuration for visibility timeout in StorageQueueMessageSource (#29567)

* [ISSUE-29566] Add configuration for visibility timeout in StorageQueueMessageSource

* [ISSUE-29566] Adding documentation to sdk/spring/CHANGELOG

Co-authored-by: Soumabrata Chakraborty <[email protected]>

* update codegen to 4.1.0 (#29633)

* mgmt, prepare release 2.16.0 (#29632)

* version_client.txt

* pom.xml

* readme.md

* changelog.md

* samples.json

* autocent

* Fix compatibility tests of deleting range (#29631)

* fix delete range
* add maven pom
* exclude wiremock-jre8

* Performance improvement for case insensitive queries (#29597)

* Performance update for case insensitive queries. No unit tests needed as functionality is already tested with existing tests.

* Fixing logic error.

* Updating logic to be more accurate, including addinga new CriteriaType function. Also added unit tests.

* Adding performance enhancing logic for IS_EQUAL and unit tests.

* Fixing IS_EQUAL performance logic related to case insensitive search and added unit tests.

* Fixing code style issues.

* Update CriteriaType.java

* Update AbstractQueryGenerator.java

* Update CriteriaType.java

* Update AbstractQueryGenerator.java

* Update AbstractQueryGenerator.java

Co-authored-by: Fabian Meiswinkel <[email protected]>

* Increment version for resourcemanager releases (#29636)

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-resources

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-storage

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-authorization

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-keyvault

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-msi

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-network

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-compute

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-sql

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-dns

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-cosmos

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-appservice

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-containerservice

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-eventhubs

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-monitor

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-containerregistry

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-appplatform

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-containerinstance

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-privatedns

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-redis

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-trafficmanager

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-servicebus

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-cdn

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager-search

* Increment package version after release of com.azure.resourcemanager azure-resourcemanager

* Update ResourceManager pipeline to use batch release (#29642)

* Update ResourceManager pipeline to use batch release

* Move azure-resourcemanager-samples to AdditionalModules

* Tracing docs improvements (#29623)

* tracing docs update

* Update Dockerfile image references to avoid using external ones (#29626)

For more info on the requirement see https://aka.ms/containers-security-guidance to remove the reference of container images from external registries

* Sync eng/common directory with azure-sdk-tools for PR 3481 (#29625)

* Support local addons path override in stress test deployment

* Support username based deployId in local stress deployment

* Support WhatIf in stress infrastructure provision script

* Simplify stress user detection

Co-authored-by: Wes Haggard <[email protected]>

* Run helm plugin add with helper

* Add WhatIf support to ps module install helper function

Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>

* Fixed merge conflicts in CHANGELOG

* Merge out from main

* Inadvertantly reversed a delta with a rebase. re-applying.

* Update spotbugs xml. with correct unit string

Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Weidong Xu <[email protected]>
Co-authored-by: Srikanta <[email protected]>
Co-authored-by: Yi Liu <[email protected]>
Co-authored-by: Shawn Fang <[email protected]>
Co-authored-by: Xiaofei Cao <[email protected]>
Co-authored-by: Sameeksha Vaity <[email protected]>
Co-authored-by: vcolin7 <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>
Co-authored-by: Fabian Meiswinkel <[email protected]>
Co-authored-by: Xiaolu Dai <[email protected]>
Co-authored-by: James Suplizio <[email protected]>
Co-authored-by: annie-mac <[email protected]>
Co-authored-by: annie-mac <[email protected]>
Co-authored-by: annie-mac <[email protected]>
Co-authored-by: annie-mac <[email protected]>
Co-authored-by: Soumabrata Chakraborty <[email protected]>
Co-authored-by: Soumabrata Chakraborty <[email protected]>
Co-authored-by: Muyao Feng <[email protected]>
Co-authored-by: Trevor Anderson <[email protected]>
Co-authored-by: Liudmila Molkova <[email protected]>
Co-authored-by: Milis <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Wes Haggard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moarychan moarychan moarychan left review comments

@jialigit jialigit jialigit left review comments

@yiliuTo yiliuTo yiliuTo approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@Netyyyy Netyyyy Awaiting requested review from Netyyyy Netyyyy is a code owner

@stliu stliu Awaiting requested review from stliu

Assignees

@saragluna saragluna

Labels
azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Status: Done
Milestone
2022-07
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Support EventHubClientBuilder bean in Event Hubs namespace level
5 participants
@saragluna @azure-sdk @jialigit @moarychan @yiliuTo