Fix sovereign clouds authority host in azure identity clients not configured bug #29409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
Netyyyy,
stliu and
yiliuTo
as code owners
ghost
added
the
|
API change check API changes are not detected in this pull request. |
saragluna
requested review from
hallipr,
weshaggard,
benbp and
JimSuplizio
as code owners
|
@saragluna do we want to look into adding sovereign cloud tests for spring (we have a "weekly" pipeline for adding additional test clouds: https://dev.azure.com/azure-sdk/internal/_build?definitionId=3723&_a=summary). This likely would have caught the authority host issue. Let me know if you'd like engsys to do this. |
|
@benbp yes and thanks!!!!!! I didn't know that weekly pipeline exists before but it surely will help us catch and prevent such issues. |
v1ct0rv
approved these changes
Jun 15, 2022
yiliuTo
reviewed
Jun 16, 2022
...azure/spring/cloud/core/implementation/credential/resolver/AzureTokenCredentialResolver.java
Show resolved
Hide resolved
...azure/spring/cloud/core/implementation/factory/AbstractAzureServiceClientBuilderFactory.java
Show resolved
Hide resolved
khmic5
pushed a commit
to daniel-rocha/azure-sdk-for-java
that referenced
this pull request
Jun 19, 2022
…figured bug (Azure#29409) * fix sovereign clouds not applied bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To fix microsoft/spring-cloud-azure#967, the authority host was not configured correctly.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines