Fully Support Null Fields when Using Custom ObjectSerializer #29238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Search
Client
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
API change check API changes are not detected in this pull request. |
|
/azp run java - search - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kasobol-msft
reviewed
Jun 7, 2022
...-search-documents/src/main/java/com/azure/search/documents/implementation/DocumentsImpl.java
Show resolved
Hide resolved
Comment on lines
+76
to
+77
| boolean startsWithCurlyBrace = documentJson.startsWith("{"); | ||
| boolean endsWithCurlyBrace = documentJson.endsWith("}"); |
There was a problem hiding this comment.
Is content expected to be trimmed? I.e. is \t\t{ ... }\n\n possible ?
There was a problem hiding this comment.
It should be trimmed given that it's serialization of the object without passing through other calls.
kasobol-msft
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #28610
Resolves a gap in functionality where a custom
ObjectSerializerwould be used to convert a customer owned type into aMap<String, Object>which would be serialized byJacksonAdapterto be sent to the service. This didn't handle null key-value pairs properly asJacksonAdapteris configured, and will continue to be configured, to ignore null values, but this defeated the purpose of the customObjectSerializerto allow for custom handling to be applied to customer owned types.Now, if an
ObjectSerializeris included in theSearchClientit will be used to convert the document into a JSON string and be injected directly into the serialized JSON, giving full control of document serialization to a customer if they choose, or need, to use it. This should also add small performance improvement as before documents would be converted to JSON to be converted into aMap<String, Object>and would then later be converted back to JSON when sending the final request. Customers not usingObjectSerializerwill continue to see the same runtime behaviors as before where null field values aren't included in the document sent to the service.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines