-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storage common property configuration supports all Storage features #29094
Add storage common property configuration supports all Storage features #29094
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. spring-cloud-azure-autoconfigure |
...e/spring/cloud/autoconfigure/implementation/storage/common/AzureStorageGlobalProperties.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/azure/spring/cloud/autoconfigure/storage/AzureStorageConfiguration.java
Outdated
Show resolved
Hide resolved
...st/java/com/azure/spring/cloud/autoconfigure/storage/AzureStorageAutoConfigurationTests.java
Show resolved
Hide resolved
...c/test/java/com/azure/spring/cloud/autoconfigure/storage/AzureStorageConfigurationTests.java
Outdated
Show resolved
Hide resolved
...pring/cloud/autoconfigure/storage/fileshare/AzureStorageFileShareAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...ure/src/main/java/com/azure/spring/cloud/autoconfigure/condition/OnAnyPropertyCondition.java
Outdated
Show resolved
Hide resolved
...ure/src/main/java/com/azure/spring/cloud/autoconfigure/condition/OnAnyPropertyCondition.java
Show resolved
Hide resolved
.../spring/cloud/autoconfigure/implementation/properties/utils/AzureServicePropertiesUtils.java
Outdated
Show resolved
Hide resolved
...ava/com/azure/spring/cloud/autoconfigure/storage/blob/AzureStorageBlobAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...st/java/com/azure/spring/cloud/autoconfigure/storage/AzureStorageAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...om/azure/spring/cloud/autoconfigure/storage/blob/AzureStorageBlobAutoConfigurationTests.java
Outdated
Show resolved
Hide resolved
...oud/autoconfigure/storage/fileshare/AzureStorageFileShareResourceAutoConfigurationTests.java
Show resolved
Hide resolved
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
...ure/src/main/java/com/azure/spring/cloud/autoconfigure/condition/OnAnyPropertyCondition.java
Outdated
Show resolved
Hide resolved
/azp run java - spring - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - spring - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
...c/test/java/com/azure/spring/cloud/autoconfigure/storage/AzureStorageConfigurationTests.java
Outdated
Show resolved
Hide resolved
.../spring/cloud/autoconfigure/implementation/properties/utils/AzureServicePropertiesUtils.java
Outdated
Show resolved
Hide resolved
...st/java/com/azure/spring/cloud/autoconfigure/storage/AzureStorageAutoConfigurationTests.java
Show resolved
Hide resolved
...c/test/java/com/azure/spring/cloud/autoconfigure/storage/AzureStorageConfigurationTests.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi @alzimmermsft, we changed some annotations for some |
At a quick glance the new ignores added to RevApi should be ignoring what is being reported, I'll need to take a deeper look to understand why this isn't happening. |
I believe what is happening is that the This PR is fixing that with two changes:
Both of these changes replicate what happens in the Analyze job, which isn't seeing the same failures. |
@alzimmermsft thanks! |
…torage_common_properties_configuration
As title.
Add properties prefixed with
spring.cloud.azure.storage
, so that common properties such asaccount-name
,connection-string
, etc. can be shared.