Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage common property configuration supports all Storage features #29094

Merged

Conversation

hui1110
Copy link
Contributor

@hui1110 hui1110 commented May 26, 2022

As title.
Add properties prefixed with spring.cloud.azure.storage, so that common properties such as account-name, connection-string, etc. can be shared.

@ghost ghost added the azure-spring All azure-spring related issues label May 26, 2022
@hui1110 hui1110 added Client This issue points to a problem in the data-plane of the library. azure-spring-storage Spring storage releated issues. labels May 26, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented May 26, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

spring-cloud-azure-autoconfigure
spring-cloud-azure-starter-storage

@hui1110
Copy link
Contributor Author

hui1110 commented May 26, 2022

#28461

@hui1110 hui1110 marked this pull request as ready for review May 26, 2022 09:24
@hui1110 hui1110 requested a review from hallipr as a code owner May 31, 2022 02:38
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@hui1110
Copy link
Contributor Author

hui1110 commented Jun 1, 2022

/azp run java - spring - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hui1110
Copy link
Contributor Author

hui1110 commented Jun 1, 2022

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@hui1110 hui1110 requested a review from mssfang as a code owner June 2, 2022 07:52
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna
Copy link
Member

Hi @alzimmermsft, we changed some annotations for some AutoConfiguration classes in this PR, which aren't breaking changes in Spring. But now it seems like the java-code-quality-reports-ci failed because of this https://dev.azure.com/azure-sdk/public/_build/results?buildId=1615699&view=results. But we marked these changes in the revapi.json file as exceptions. Do you know how to make the java-code-quality-reports-ci ignore them too?

@alzimmermsft
Copy link
Member

Hi @alzimmermsft, we changed some annotations for some AutoConfiguration classes in this PR, which aren't breaking changes in Spring. But now it seems like the java-code-quality-reports-ci failed because of this https://dev.azure.com/azure-sdk/public/_build/results?buildId=1615699&view=results. But we marked these changes in the revapi.json file as exceptions. Do you know how to make the java-code-quality-reports-ci ignore them too?

At a quick glance the new ignores added to RevApi should be ignoring what is being reported, I'll need to take a deeper look to understand why this isn't happening.

@alzimmermsft
Copy link
Member

Hi @alzimmermsft, we changed some annotations for some AutoConfiguration classes in this PR, which aren't breaking changes in Spring. But now it seems like the java-code-quality-reports-ci failed because of this https://dev.azure.com/azure-sdk/public/_build/results?buildId=1615699&view=results. But we marked these changes in the revapi.json file as exceptions. Do you know how to make the java-code-quality-reports-ci ignore them too?

At a quick glance the new ignores added to RevApi should be ignoring what is being reported, I'll need to take a deeper look to understand why this isn't happening.

I believe what is happening is that the code-quality-reports pipeline builds and installs the code-quality-reports library before downloading the DevOps cached Maven cache which overwrites any new changes if there was a cache hit. And the previous runs in the PR did have a cache hit.

This PR is fixing that with two changes:

  • The Maven cache is cleaned before DevOps can cache it by removing all com.azure libraries.
  • Installation of the code-quality-reports project happens after the cache is downloaded.

Both of these changes replicate what happens in the Analyze job, which isn't seeing the same failures.

@saragluna
Copy link
Member

@alzimmermsft thanks!

@hui1110 hui1110 requested a review from JimSuplizio as a code owner June 8, 2022 01:41
@hui1110 hui1110 merged commit 0c41112 into Azure:main Jun 8, 2022
@hui1110 hui1110 self-assigned this Jun 8, 2022
@hui1110 hui1110 added this to the [2022] July milestone Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues azure-spring-storage Spring storage releated issues. Client This issue points to a problem in the data-plane of the library.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] A new Spring Cloud Azure Storage starter supports all Storage features
5 participants