Suppress nested SDK public method calls #28998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
lmolkova
commented
May 20, 2022
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package com.azure.core.tracing.opentelemetry.implementation; |
There was a problem hiding this comment.
it's not needed anymore. This code was interacting with OTel Java agent, but now the agent contains Azure SDK instrumentation (thanks to Trask 🥳) and we don't need the suppression here.
This code was also noop because of OTel instrumentation API changes.
|
API change check API changes are not detected in this pull request. |
trask
reviewed
May 20, 2022
...e-tracing-opentelemetry/src/test/java/com/azure/core/tracing/opentelemetry/TestExporter.java
Outdated
Show resolved
Hide resolved
...ng-opentelemetry/src/main/java/com/azure/core/tracing/opentelemetry/OpenTelemetryTracer.java
Outdated
Show resolved
Hide resolved
...pentelemetry/src/test/java/com/azure/core/tracing/opentelemetry/OpenTelemetryTracerTest.java
Outdated
Show resolved
Hide resolved
lmolkova
requested review from
g2vinay,
JonathanGiles,
backwind1233,
chenrujun,
hui1110,
jialigit,
Netyyyy,
saragluna,
stliu and
yiliuTo
as code owners
anushkasingh16
pushed a commit
to anushkasingh16/azure-sdk-for-java
that referenced
this pull request
Jun 6, 2022
* Suppress nested SDK public method calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support building convenience methods on top of DPG clients better, we want to avoid having multiple spans for public API calls and came up with the following guidance (not yet documented, but on the way):
"one SDK client span per customer method invocation with however many nested HTTP spans underneath”
(
clientspan here refers to SDK client, not to span kind which can beinternalorclientfor such calls).This change suppresses
internalorclientspans nested under otherinternalorclientspans.Example:
BlobClient.SetMetadaor
MetricAdvisor.autoGeneratedMethodCall (internal)In theory this is a breaking change in behavior, but since
azure-core-tracing-opentelemetrypackage is in beta and the change is contained there, we're still able to make it