Small bug fixes for core. #28047
Merged
Small bug fixes for core. #28047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallavit
requested review from
alzimmermsft,
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles,
billwert and
kasobol-msft
as code owners
|
API change check for API changes are not detected in this pull request for |
alzimmermsft
reviewed
Apr 6, 2022
sdk/core/azure-core/src/test/java/com/azure/core/http/MockHttpResponse.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Apr 6, 2022
…Response.java Co-authored-by: Alan Zimmer <[email protected]>
ghost
added
the
no-recent-activity
|
Hi @pallavit. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
@alzimmermsft want to merge this PR? |
ghost
removed
the
no-recent-activity
Comment on lines
+81
to
+89
| // Both Netty and OkHttp expect the requestBody to be closed after the response has been read. | ||
| // Failure to do so results in memory leak. | ||
| // In case of StreamResponse (or other scenarios where we do not eagerly read the response) | ||
| // the response body may not be consumed. | ||
| // This can cause potential leaks in the scenarios like above, where the policy | ||
| // may intercept the response and it may never be read. | ||
| // Forcing the read here - so that the memory can be released. | ||
| return httpResponse.getBody().ignoreElements() | ||
| .then(nextPolicy.process()); |
There was a problem hiding this comment.
fwiw we should start using HttpResponse.close for this.
khmic5
pushed a commit
to daniel-rocha/azure-sdk-for-java
that referenced
this pull request
Jun 19, 2022
Small bug fixes for core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description