Fix issues in bom and pom files #27850
Conversation
saragluna
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
stliu,
yiliuTo,
joshfree,
srnagar,
anuchandy,
conniey,
pallavit,
lmolkova and
JonathanGiles
as code owners
ghost
added
the
| <artifactId>azure-core</artifactId> | ||
| <version>1.26.0</version> <!-- {x-version-update;com.azure:azure-core;dependency} --> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-cosmos</artifactId> | ||
| <artifactId>azure-cosmos</artifactId> <!-- Spring Cloud Azure is tested with 4.28.0 --> | ||
| <version>4.28.0</version> <!-- {x-version-update;com.azure:azure-cosmos;dependency} --> |
There was a problem hiding this comment.
@pallavit please take a look at this, cosmos releases two versions this month, CHANGELOG.md#4280-2022-03-18, but the azure-sdk-bom contains the first version, but the version used in our code is 4.28.0. So here instead of using the version from the SDK bom, I chose the 4.28.0 in our bom.
|
@jialigit please update the migration guide of the jms starter, to include a section like this https://github.com/microsoft/spring-cloud-azure/blob/4.0.0-beta.4/docs/src/main/asciidoc/_migration-guide-for-4.0.adoc#dependency-changes-2. To give people some hints that we've removed the netty dependencies from the jms starter. |
|
May explain the reason why do these changes , benefits and drawbacks? Maybe we should keep a checklist to check it always as we go. |
Spring Boot will manage the netty versions, but the qpid version we are using here depends on a older version of netty, if users depend on both jms starter and other sdk starter, the netty version comes with SDK will be omitted for conflicting with netty version comes with qpid. So here we can't remove the netty from the jms starter, I will rollback the change. |
This PR will: