Change the setClientFactoryCustomizers to addClientFactoryCustomizer #27775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
stliu and
yiliuTo
as code owners
ghost
added
the
|
API changes have been detected in |
|
API changes have been detected in |
chenrujun
reviewed
Mar 22, 2022
| public void setProducerFactoryCustomizers(List<EventHubsProducerFactoryCustomizer> producerFactoryCustomizers) { | ||
| this.producerFactoryCustomizers = producerFactoryCustomizers; | ||
| public void addProducerFactoryCustomizer(EventHubsProducerFactoryCustomizer producerFactoryCustomizer) { | ||
| if (producerFactoryCustomizer != null) { |
There was a problem hiding this comment.
When will producerFactoryCustomizer be null?
There was a problem hiding this comment.
this could be call by users
| this.producerFactoryCustomizers = producerFactoryCustomizers; | ||
| public void addProducerFactoryCustomizer(EventHubsProducerFactoryCustomizer producerFactoryCustomizer) { | ||
| if (producerFactoryCustomizer != null) { | ||
| this.producerFactoryCustomizers.add(producerFactoryCustomizer); |
There was a problem hiding this comment.
Do we need to consider thread-safe here?
| @@ -110,8 +108,8 @@ public EventHubsMessageChannelBinder eventHubBinder(EventHubsChannelProvisioner | |||
| binder.setBindingProperties(bindingProperties); | |||
| binder.setNamespaceProperties(namespaceProperties.getIfAvailable()); | |||
| checkpointStores.ifAvailable(binder::setCheckpointStore); | |||
| binder.setProducerFactoryCustomizers(producerFactoryCustomizers.orderedStream().collect(Collectors.toList())); | |||
| binder.setProcessorFactoryCustomizers(processorFactoryCustomizers.orderedStream().collect(Collectors.toList())); | |||
| producerFactoryCustomizers.orderedStream().forEach(binder::addProducerFactoryCustomizer); | |||
There was a problem hiding this comment.
How about adding addProducerFactoryCustomizers to support add multiple customizers one time?
There was a problem hiding this comment.
not for now, but maybe in later versions
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the API of
setClientFactoryCustomizers(List<ClientFactoryCustomizer> customizers)toaddClientFactoryCustomizer(ClientFactoryCustomizer customizer)so the autoconfigured client factory customizers will still be available.