Address health indicator API review comments #27706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moarychan
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
azure-spring
|
Thank you for your contribution moarychan! We will review the pull request and get back to you soon. |
saragluna
requested changes
Mar 16, 2022
| @@ -31,7 +31,7 @@ public KeyVaultSecretHealthIndicator(SecretAsyncClient secretAsyncClient) { | |||
| @Override | |||
| protected void doHealthCheck(Health.Builder builder) { | |||
| try { | |||
| this.secretAsyncClient.getSecretWithResponse("azure-spring-none-existing-secret", "") | |||
| this.secretAsyncClient.getSecretWithResponse("spring-cloud-azure-none-existing-secret", "") | |||
There was a problem hiding this comment.
please help change to spring-cloud-azure-not-existing-xx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address health indicator API review comments.
Changelog: