-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more hints for map properties config #27665
Merged
saragluna
merged 6 commits into
Azure:feature/azure-spring-cloud-4.0
from
moarychan:moary/add-more-hits-config
Mar 16, 2022
Merged
Add more hints for map properties config #27665
saragluna
merged 6 commits into
Azure:feature/azure-spring-cloud-4.0
from
moarychan:moary/add-more-hits-config
Mar 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-sdk-for-java into moary/add-more-hits-config
moarychan
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
saragluna,
stliu and
yiliuTo
as code owners
March 15, 2022 01:50
ghost
added
azure-spring
All azure-spring related issues
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
labels
Mar 15, 2022
Thank you for your contribution moarychan! We will review the pull request and get back to you soon. |
saragluna
changed the title
Add more hits for map properties config
Add more hints for map properties config
Mar 15, 2022
saragluna
requested changes
Mar 15, 2022
...spring/cloud/autoconfigure/implementation/eventhubs/properties/AzureEventHubsProperties.java
Outdated
Show resolved
Hide resolved
...spring/cloud/autoconfigure/implementation/eventhubs/properties/AzureEventHubsProperties.java
Show resolved
Hide resolved
saragluna
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
azure-spring
All azure-spring related issues
customer-reported
Issues that are reported by GitHub users external to the Azure organization.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26600
Changelog: