Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more hints for map properties config #27665

Conversation

moarychan
Copy link
Member

@moarychan moarychan commented Mar 15, 2022

Fixes #26600

Changelog:

  • Add hints for map properties keys
  • Add final for map attribute in AAD proeprties

@ghost ghost added azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Mar 15, 2022
@ghost
Copy link

ghost commented Mar 15, 2022

Thank you for your contribution moarychan! We will review the pull request and get back to you soon.

@saragluna saragluna changed the title Add more hits for map properties config Add more hints for map properties config Mar 15, 2022
@saragluna saragluna self-assigned this Mar 15, 2022
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna merged commit ff2439f into Azure:feature/azure-spring-cloud-4.0 Mar 16, 2022
@moarychan moarychan deleted the moary/add-more-hits-config branch March 29, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants