Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design the configuration properties about key vault secrets #27651

Conversation

chenrujun
Copy link

Fix #27392

@ghost ghost added the azure-spring All azure-spring related issues label Mar 14, 2022
@chenrujun
Copy link
Author

Hi, @saragluna , @yiliuTo , please help to review this PR when you have time.

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-core. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here

@chenrujun
Copy link
Author

FYI:
100% coverage for both methods and lines.

image

@chenrujun chenrujun self-assigned this Mar 15, 2022
@chenrujun chenrujun added the Client This issue points to a problem in the data-plane of the library. label Mar 15, 2022
@chenrujun chenrujun added this to the Spring Cloud Azure 4.0 GA milestone Mar 15, 2022
Copy link
Author

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chenrujun
Copy link
Author

/azp run java - spring - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun chenrujun closed this Mar 15, 2022
@chenrujun chenrujun reopened this Mar 15, 2022
@chenrujun chenrujun force-pushed the update-logic-of-key-vault-secret-property-source branch from 1b7afd7 to 4e8a49d Compare March 15, 2022 07:23
@chenrujun chenrujun merged commit 1311533 into Azure:feature/azure-spring-cloud-4.0 Mar 15, 2022
@chenrujun chenrujun deleted the update-logic-of-key-vault-secret-property-source branch March 15, 2022 08:03
@chenrujun chenrujun linked an issue Mar 15, 2022 that may be closed by this pull request
chenrujun pushed a commit to chenrujun/azure-sdk-for-java that referenced this pull request Mar 18, 2022
chenrujun pushed a commit that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Re-design the configuration properties about key vault secrets.
4 participants