Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix credential bugs #27626

Merged
merged 4 commits into from
Mar 14, 2022
Merged

fix credential bugs #27626

merged 4 commits into from
Mar 14, 2022

Conversation

yiliuTo
Copy link
Member

@yiliuTo yiliuTo commented Mar 11, 2022 •
edited
Loading

This pr is to fix credential related bugs including:

  1. Fail to use resource manager to retrieve connection string.
  2. Default token credential still takes effects when other token credentials are provided.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 11, 2022
@yiliuTo yiliuTo added the Client This issue points to a problem in the data-plane of the library. label Mar 11, 2022
@yiliuTo
Copy link
Member Author

yiliuTo commented Mar 11, 2022

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-eventhubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-servicebus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-stream-binder-servicebus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-stream-binder-eventhubs. You can review API changes here

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@yiliuTo yiliuTo marked this pull request as ready for review March 14, 2022 01:13
@yiliuTo
Copy link
Member Author

yiliuTo commented Mar 14, 2022

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna requested changes Mar 14, 2022
View reviewed changes
...com/azure/spring/cloud/autoconfigure/eventhubs/AzureEventHubsMessagingAutoConfiguration.java Outdated Show resolved Hide resolved
...m/azure/spring/cloud/autoconfigure/servicebus/AzureServiceBusMessagingAutoConfiguration.java Outdated
connectionStringProviders.getIfAvailable();
if (connectionStringProvider != null) {
namespaceProperties.setConnectionString(connectionStringProvider.getConnectionString());
LOGGER.warn("Service Bus connection string is set now.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

...ain/java/com/azure/spring/cloud/stream/binder/servicebus/ServiceBusMessageChannelBinder.java Outdated Show resolved Hide resolved
saragluna
saragluna approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yiliuTo yiliuTo merged commit a9a2a67 into Azure:feature/azure-spring-cloud-4.0 Mar 14, 2022
@saragluna saragluna added this to the Spring Cloud Azure 4.0 GA milestone Mar 14, 2022
@yiliuTo yiliuTo mentioned this pull request Mar 24, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@stliu stliu Awaiting requested review from stliu

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 GA
Development

Successfully merging this pull request may close these issues.
3 participants
@yiliuTo @azure-sdk @saragluna