Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address apiview comments #27586

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Address apiview comments #27586

merged 4 commits into from
Mar 11, 2022

Conversation

saragluna
Copy link
Member

This PR will address the API view comments, to:

  • Change the retry options to: 
        mode: 'exponential' (default) or 'fixed'
    exponential:
      max-retries: 
      base-delay:
      max-delay: 
    fixed:
      max-retries: 
      delay:
  • Some small changes about public scopes
  • Refactor the UT structure in spring-cloud-azure-service.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 10, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-core. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-service. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-eventhubs. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-servicebus. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-messaging-azure-storage-queue. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure.spring:spring-cloud-azure-autoconfigure. You can review API changes here

backwind1233
backwind1233 reviewed Mar 10, 2022
View reviewed changes
...e/src/main/java/com/azure/spring/cloud/autoconfigure/cloudfoundry/environment/Constants.java Outdated

// VCAP credential key names
/**
* Shared access key name
*/
public static final String SHARED_ACCESS_NAME = "shared_access_key_name";
static final String SHARED_ACCESS_NAME = "shared_access_key_name";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to change
from SHARED_ACCESS_NAME to SHARED_ACCESS_KEY_NAME

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can do that

@saragluna
Copy link
Member Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

moarychan
moarychan reviewed Mar 11, 2022
View reviewed changes
...ava/com/azure/spring/cloud/core/implementation/converter/AzureAmqpRetryOptionsConverter.java

return result;
mapper.from(retry.getTryTimeout()).to(result::setTryTimeout);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AmqpRetryOptions has the default value for properties, if not applied, it will use the default value, should we add logs to tell the user which value is used? Or ensure consistent configuration and behavior, we can add a default value for the to method,
mapper.from(retry.getTryTimeout()).to(result::setTryTimeout, null);

moarychan
moarychan approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@moarychan moarychan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna added this to the Spring Cloud Azure 4.0 GA milestone Mar 11, 2022
@saragluna saragluna merged commit 0c33c3a into Azure:feature/azure-spring-cloud-4.0 Mar 11, 2022
@saragluna saragluna deleted the xiada/address-apiview-comments3 branch March 17, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@backwind1233 backwind1233 backwind1233 left review comments

@moarychan moarychan moarychan approved these changes

@chenrujun chenrujun Awaiting requested review from chenrujun

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 GA
Development

Successfully merging this pull request may close these issues.
4 participants
@saragluna @azure-sdk @backwind1233 @moarychan