To address the API review comments #27511
Conversation
saragluna
requested review from
mssfang,
JonathanGiles,
backwind1233,
chenrujun,
hui1110,
jialigit,
stliu and
yiliuTo
as code owners
ghost
added
the
|
API changes have been detected in |
|
API changes have been detected in |
|
API changes have been detected in |
| private boolean enabled; | ||
| /** | ||
| * Comma-delimited list of compatible Spring Boot versions. |
There was a problem hiding this comment.
comment may not correctly describe the field.
There was a problem hiding this comment.
Do you have suggestions for this?
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @Bean | ||
| @ConditionalOnMissingBean | ||
| @ConditionalOnMissingProperty(prefix = "spring.jms.servicebus", name = "connection-string") | ||
| public static AzureServiceBusJmsPropertiesBeanPostProcessor azureServiceBusJmsPropertiesBeanPostProcessor(ObjectProvider<ConnectionStringProvider<AzureServiceType.ServiceBus>> connectionStringProviders) { | ||
| public static AzureServiceBusJmsPropertiesBeanPostProcessor azureServiceBusJmsPropertiesBeanPostProcessor( | ||
| ObjectProvider<ConnectionStringProvider<AzureServiceType.ServiceBus>> connectionStringProviders) { |
There was a problem hiding this comment.
why arg name use plural style?
There was a problem hiding this comment.
this is not the change of this pr, but when you use ObjectProvider, it means there could be multiple such objects.
...n/java/com/azure/spring/cloud/autoconfigure/jms/properties/AzureServiceBusJmsProperties.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Get the login user of the AMQP broker. | ||
| * @return the login user of the AMQP broker. | ||
| */ |
There was a problem hiding this comment.
why need comments in both field and getters at the same time?
There was a problem hiding this comment.
The architects ask us to do so.
|
API changes have been detected in |
|
API changes have been detected in |
|
API changes have been detected in |
|
API changes have been detected in |
|
API changes have been detected in |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
To address the API review comments, this PR will:
*OptionsAwareto*OptionsProviderClient,Retryand others toClientOptions,RetryOptionsand*Options.headersproperties out from theClientOptionsand put it into theHttpClientOptionsbecauseAzureServiceType.