Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete AadJwtClaimValidator, use JwtClaimValidator instead. #27365

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Delete AadJwtClaimValidator, use JwtClaimValidator instead. #27365

merged 1 commit into from
Mar 7, 2022

Conversation

chenrujun
Copy link

  1. Delete AadJwtClaimValidator, use JwtClaimValidator instead.
  2. Delete AadJwtAudienceValidator, use JwtClaimValidator instead.
  3. Rename AadTokenClaim to AadJwtClaimNames, and enrich java doc.

@rujche
1. Delete AadJwtClaimValidator, use JwtClaimValidator instead.
356a75e 
2. Delete AadJwtAudienceValidator, use JwtClaimValidator instead.
3. Rename AadTokenClaim to AadJwtClaimNames, and enrich java doc.
@ghost ghost added the azure-spring All azure-spring related issues label Mar 1, 2022
@chenrujun chenrujun self-assigned this Mar 1, 2022
@chenrujun chenrujun added the Client This issue points to a problem in the data-plane of the library. label Mar 1, 2022
@chenrujun chenrujun added this to the [2022] March milestone Mar 1, 2022
@chenrujun chenrujun changed the title 1. Delete AadJwtClaimValidator, use JwtClaimValidator instead. Delete AadJwtClaimValidator, use JwtClaimValidator instead. Mar 1, 2022
@chenrujun chenrujun linked an issue Mar 1, 2022 that may be closed by this pull request
Delete AADJwtClaimValidator, use JwtClaimValidator instead. #27030
Closed
@chenrujun
Copy link
Author

Hi, @backwind1233 , @saragluna , please help to review this PR when you have time.

saragluna
saragluna approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please make sure reference doc and samples are also changed if needed.

@chenrujun chenrujun merged commit e4c9030 into Azure:feature/azure-spring-cloud-4.0 Mar 7, 2022
@chenrujun chenrujun deleted the issue-27030-use-JwtClaimValidator-instead-of-AADJwtClaimValidator branch March 7, 2022 02:12
@saragluna saragluna mentioned this pull request Mar 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@hui1110 hui1110 Awaiting requested review from hui1110

@jialigit jialigit Awaiting requested review from jialigit

@stliu stliu Awaiting requested review from stliu

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
Spring Cloud Azure
Status: Done
Milestone
Spring Cloud Azure 4.0 GA
Development

Successfully merging this pull request may close these issues.

Delete AADJwtClaimValidator, use JwtClaimValidator instead.
3 participants
@chenrujun @saragluna @rujche