Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Spring Cloud Azure retry options #27332

Conversation

saragluna
Copy link
Member

@saragluna saragluna commented Feb 28, 2022

As title. To address comments on retry properties: #26970.

amqp.retry:
    max-retries:
    base-delay:
    max-delay:
    try-timeout:
    mode: 'exponential' (default) or 'fixed'
http.retry: 
    mode: 'exponential' (default) or 'fixed'
    exponential:
      max-retries: 
      base-delay:
      max-delay: 
    fixed:
      max-retries: 
      delay:

We also propose to not configure

    retry-after-header
    retry-after-time-unit

This configuration is no longer needed and used to be required by some services (not for users to configure)

Now the configuration properties for HTTP clients will be:

spring.cloud.azure.xxx.retry:
  max-retries: 2
  base-delay: 10s
  max-delay: 2m
  mode: fixed

and AMQP clients will be:

spring.cloud.azure.xxx.retry:
  max-retries: 2
  base-delay: 10s
  max-delay: 2m
  mode: fixed
  try-timeout: 5s

@ghost ghost added the azure-spring All azure-spring related issues label Feb 28, 2022
@saragluna saragluna self-assigned this Feb 28, 2022
@saragluna saragluna merged commit 344dce8 into Azure:feature/azure-spring-cloud-4.0 Feb 28, 2022
@saragluna saragluna deleted the xiada/refactor-retry-options branch March 17, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants