Change non-sdk defined boolean types from Boolean to boolean #27321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
stliu and
yiliuTo
as code owners
ghost
added
the
yiliuTo
reviewed
Feb 28, 2022
...zure/spring/cloud/autoconfigure/eventhubs/AzureEventHubsClientBuilderConfigurationTests.java
Outdated
Show resolved
Hide resolved
|
Merge this now, the test coverage is fixed in #27322. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Spring Cloud Azure 4.0, we define those boolean switches derived from SDK as
Booleanto avoid changing the default value to them. But we should usebooleanfor the types we defined. This PR will change the type for these fields and add more tests for configuration properties.