Move the classes that need to be hidden to the implementation package #27281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
…re-sdk-for-java into feature/azure-spring-cloud-4.0
ghost
added
the
hui1110
requested review from
backwind1233,
chenrujun,
jialigit,
saragluna,
stliu and
yiliuTo
as code owners
saragluna
requested changes
Feb 24, 2022
| @@ -7,8 +7,8 @@ | |||
| import com.azure.spring.cloud.stream.binder.eventhubs.properties.EventHubsProducerProperties; | |||
| import com.azure.spring.cloud.stream.binder.eventhubs.provisioning.EventHubsChannelProvisioner; | |||
| import com.azure.spring.integration.eventhubs.inbound.EventHubsInboundChannelAdapter; | |||
| import com.azure.spring.integration.handler.DefaultMessageHandler; | |||
| import com.azure.spring.integration.instrumentation.DefaultInstrumentation; | |||
| import com.azure.spring.integration.implementation.DefaultMessageHandler; | |||
There was a problem hiding this comment.
should we keep the package as implementation.handler?
...t/java/com/azure/spring/cloud/stream/binder/eventhubs/TestEventHubsMessageChannelBinder.java
Show resolved
Hide resolved
| @@ -15,7 +15,7 @@ | |||
| import com.azure.spring.eventhubs.core.EventHubsProcessorContainer; | |||
| import com.azure.spring.eventhubs.core.EventHubsTemplate; | |||
| import com.azure.spring.eventhubs.implementation.core.DefaultEventHubsNamespaceProducerFactory; | |||
| import com.azure.spring.integration.eventhubs.inbound.health.EventHubsProcessorInstrumentation; | |||
| import com.azure.spring.integration.eventhubs.inbound.implementation.EventHubsProcessorInstrumentation; | |||
There was a problem hiding this comment.
should we keep the package as implementation. health ?
saragluna
requested changes
Feb 24, 2022
| @@ -3,6 +3,7 @@ | |||
|
|
|||
| package com.azure.spring.integration.handler; | |||
|
|
|||
| import com.azure.spring.integration.implementation.handler.DefaultMessageHandler; | |||
There was a problem hiding this comment.
also apply the change to the test packages.
35 tasks
…re-sdk-for-java into yonghui/apiview_spring_integration_module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title:
This PR is only for these modules:
spring-integration-azure-core.
apiview page: https://apiview.dev/Assemblies/Review/8735674810ed48ac8533cfce1f671c10
spring-integration-azure-eventhubs.
apiview page: https://apiview.dev/Assemblies/Review/b3de6a9b52934debbbb2525f616081df
spring-integration-azure-servicebus.
apiview page: https://apiview.dev/Assemblies/Review/2b2c8a902da043ff8d0114f1ae3244c7