-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cosmos permissions properties and set default connection mode #27236
Remove cosmos permissions properties and set default connection mode #27236
Conversation
ce17d3e
to
74f492a
Compare
…ion mode to direct
74f492a
to
c22b640
Compare
/** | ||
* Permission list which contains the resource tokens needed to access resources. | ||
*/ | ||
private final List<CosmosPermissionProperties> permissions = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test properties should be removed in sync,
Line 41 in c8a7610
private final List<CosmosPermissionProperties> permissions = new ArrayList<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in another PR.
@@ -97,7 +92,7 @@ | |||
/** | |||
* Connection mode to be used by the client in the Azure Cosmos DB database service. | |||
*/ | |||
private ConnectionMode connectionMode; | |||
private ConnectionMode connectionMode = ConnectionMode.DIRECT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test properties should be updated in sync, com.azure.spring.service.implementation.cosmos.TestAzureCosmosHttpProperties#connectionMode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Per discussion with the architects:
#27112