Make the credential resolver configurable in Spring Cloud Azure #26792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saragluna
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
JonathanGiles,
mssfang,
stliu and
yiliuTo
as code owners
ghost
added
the
…-credential-builder-configurable
jialigit
reviewed
Feb 9, 2022
...java/com/azure/spring/cloud/autoconfigure/context/AzureTokenCredentialAutoConfiguration.java
Show resolved
Hide resolved
...java/com/azure/spring/cloud/autoconfigure/context/AzureTokenCredentialAutoConfiguration.java
Show resolved
Hide resolved
...re/src/main/java/com/azure/spring/core/factory/AbstractAzureServiceClientBuilderFactory.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/com/azure/spring/core/factory/AbstractAzureServiceClientBuilderFactory.java
Show resolved
Hide resolved
...re/src/main/java/com/azure/spring/core/factory/AbstractAzureServiceClientBuilderFactory.java
Show resolved
Hide resolved
.../java/com/azure/spring/eventhubs/core/producer/DefaultEventHubsNamespaceProducerFactory.java
Show resolved
Hide resolved
.../java/com/azure/spring/eventhubs/core/producer/DefaultEventHubsNamespaceProducerFactory.java
Show resolved
Hide resolved
...a/com/azure/spring/servicebus/core/processor/DefaultServiceBusNamespaceProcessorFactory.java
Show resolved
Hide resolved
...a/com/azure/spring/servicebus/core/processor/DefaultServiceBusNamespaceProcessorFactory.java
Show resolved
Hide resolved
...ava/com/azure/spring/servicebus/core/producer/DefaultServiceBusNamespaceProducerFactory.java
Show resolved
Hide resolved
moarychan
reviewed
Feb 9, 2022
...n/java/com/azure/spring/core/factory/credential/ManagedIdentityCredentialBuilderFactory.java
Outdated
Show resolved
Hide resolved
moarychan
reviewed
Feb 9, 2022
...re/src/main/java/com/azure/spring/core/factory/AbstractAzureServiceClientBuilderFactory.java
Show resolved
Hide resolved
moarychan
reviewed
Feb 9, 2022
...src/main/java/com/azure/spring/core/factory/credential/AzureAadCredentialBuilderFactory.java
Outdated
Show resolved
Hide resolved
saragluna
deleted the
xiada/feature/make-credential-builder-configurable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now if we configure the credential info under each SDK namespace, such as
spring.cloud.azure.keyvault.secret.credential.client-id, a newTokenCredentialwill be constructed without opportunitity to configureHttpClient,RetryOptions, andProxyOptions. This PR is to