Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoconfiguration for file share directoryclient #26645

Conversation

saragluna
Copy link
Member

To resolve #24413.

  • Add auto-configuration for FileShare directory client.
  • Change configuration name from file-name to file-path and add directory-path.

… configuration properties from file-name to file-path
@ghost ghost added the azure-spring All azure-spring related issues label Jan 24, 2022
Copy link
Contributor

@backwind1233 backwind1233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@backwind1233
Copy link
Contributor

backwind1233 commented Jan 24, 2022

Do you think we should add some information in our reference doc or samples to demonstrate this? @saragluna

@saragluna
Copy link
Member Author

Do you think we should add some information in our reference doc or samples to demonstrate this? @saragluna

We can add something in the Javadoc like this:

SMTP server host. For instance, 'smtp.example.com'.

@saragluna saragluna changed the title Aadd autoconfiguration for file share directoryclient Add autoconfiguration for file share directoryclient Jan 24, 2022
@backwind1233
Copy link
Contributor

I don't get it.

@saragluna saragluna merged commit fb18c50 into Azure:feature/azure-spring-cloud-4.0 Jan 24, 2022
@saragluna saragluna deleted the xiada/feature/add-autoconfiguration-for-directoryclient branch March 17, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
azure-spring All azure-spring related issues
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants