Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the bug of consumer group autocreation in binder #26622

Merged
merged 3 commits into from
Jan 21, 2022
Merged

fix the bug of consumer group autocreation in binder #26622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
905cf14
fix consumer group autocreation in binder
yiliuTo Jan 21, 2022
20adff1
add changelog
yiliuTo Jan 21, 2022
30cac16
udpate changelog
yiliuTo Jan 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sdk/spring/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Release History

## 4.0.0-beta.4 (Unreleased)

### Spring Cloud Azure Resource Manager
This section includes changes in the `spring-cloud-azure-resourcemanager` module.

#### Bugs Fixed
- Fix the bug that the auto-created consumer group takes the name of Event Hub [#26622](https://github.com/Azure/azure-sdk-for-java/pull/26622).

### Other Changes

## 4.0.0-beta.3 (2022-01-18)
Please refer to [Spring Cloud Azure Migration Guide for 4.0](https://microsoft.github.io/spring-cloud-azure/4.0.0-beta.3/4.0.0-beta.3/reference/html/appendix.html#migration-guide-for-4-0) to learn how to migrate to version 4.0.

Expand Down
2 changes: 1 addition & 1 deletion ...java/com/azure/spring/resourcemanager/implementation/crud/EventHubsConsumerGroupCrud.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public EventHubConsumerGroup internalCreate(Tuple3<String, String, String> consu
return this.resourceManager
.eventHubs()
.consumerGroups()
.define(consumerGroupCoordinate.getT2())
.define(consumerGroupCoordinate.getT3())
.withExistingEventHub(new EventHubsCrud(this.resourceManager, this.resourceMetadata)
.getOrCreate(Tuples.of(consumerGroupCoordinate.getT1(),
consumerGroupCoordinate.getT2())))
Expand Down