Delete deprecated configuration properties for aad and aadb2c. #26598
Conversation
chenrujun
commented
Jan 20, 2022
chenrujun
commented
- Delete deprecated configuration properties for aad and aadb2c.
- Update java doc for configuration properties for aad and aadb2c.
2. Update java doc for configuration properties for aad and aadb2c.
chenrujun
requested review from
backwind1233,
hui1110,
jialigit,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
the
|
Hi, @saragluna , @moarychan , please help to review this PR when you have time. |
chenrujun
added
azure-spring-aad
|
|
||
| /** | ||
| * If true activates the stateless auth filter AADAppRoleStatelessAuthenticationFilter. The | ||
| * default is false which activates AADAuthenticationFilter. | ||
| */ | ||
| private Boolean sessionStateless = false; | ||
|
|
||
| /** | ||
| * The OAuth2 authorization clients. | ||
| */ |
There was a problem hiding this comment.
Later we can have more hints added for this map https://docs.spring.io/spring-boot/docs/current/reference/html/configuration-metadata.html#configuration-metadata.manual-hints.value-hint
| /** | ||
| * Configure which claim will be used to build GrantedAuthority, and prefix of the GrantedAuthority's string value. | ||
| * Default value is: "scp" -> "SCOPE_", "roles" -> "APPROLE_". | ||
| * @see org.springframework.security.core.GrantedAuthority | ||
| * @see org.springframework.security.core.GrantedAuthority . |
There was a problem hiding this comment.
We should remove this @see xxxx, the @see won't do much help in the metadata.
https://docs.spring.io/spring-boot/docs/current/reference/html/configuration-metadata.html#configuration-metadata.annotation-processor
"
You should only use plain text with @ConfigurationProperties field Javadoc, since they are not processed before being added to the JSON.
"
| @@ -108,10 +100,13 @@ | |||
| */ | |||
| private String loginFlow = DEFAULT_KEY_SIGN_UP_OR_SIGN_IN; | |||
|
|
|||
| /** | |||
| * User flows. | |||
| */ | |||
There was a problem hiding this comment.
Same here, more hints could be added later.
2. Fix error about exception description. 3. Fix typo. 4. Fix logic error of property validation.
…configuration-properties-for-aad-and-aad-b2c
chenrujun
deleted the
delete-deprecated-configuration-properties-for-aad-and-aad-b2c
branch
