Modify spring-cloud-azure-core, spring-cloud-azure-service, and spring-cloud-azure-resourcemanager according to API review comments #25851
Conversation
saragluna
requested review from
backwind1233,
chenrujun,
hui1110,
jialigit,
JonathanGiles,
mssfang,
stliu and
yiliuTo
as code owners
ghost
added
the
|
API changes have been detected in |
…ng-cloud-azure-apiview
|
API changes have been detected in API changes - public static final Region SWEDEN_CENTRAL = new Region("swedencentral", "Sweden Central"); |
…ng-cloud-azure-apiview
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
saragluna
changed the title
| @@ -129,14 +129,14 @@ public Processor getProcessor() { | |||
| /** | |||
| * Properties of an Event Hub producer. | |||
| */ | |||
| public static class Producer extends AzureEventHubsCommonProperties implements EventHubsProducerDescriptor { | |||
| public static class Producer extends AzureEventHubsCommonProperties implements EventHubProducerProperties { | |||
There was a problem hiding this comment.
need we rename EventHubsProducerDescriptor to EventHubProducerClientProperties?
There was a problem hiding this comment.
Given Event Hubs only have one client builder, EventHubClientBuilder, so we won't call it EventHubProducerClientProperties.
|
|
||
| } | ||
|
|
||
| /** | ||
| * Properties of an Event Hub consumer. | ||
| */ | ||
| public static class Consumer extends AzureEventHubsCommonProperties implements EventHubsConsumerDescriptor { | ||
| public static class Consumer extends AzureEventHubsCommonProperties implements EventHubConsumerProperties { |
There was a problem hiding this comment.
need we rename EventHubsConsumerDescriptor to EventHubConsumerClientProperties?
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The spring-cloud-azure-core is being reviewed by the architects, this PR is to apply the changes according to comments.
spring-cloud-azure-core: spring-cloud-azure-core (version 4.0.0-beta.3) - apiview.dev
spring-cloud-azure-service: spring-cloud-azure-service (version 4.0.0-beta.3) - apiview.dev
spring-cloud-azure-resourcemanager: spring-cloud-azure-resourcemanager (version 4.0.0-beta.3) - apiview.dev