Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade spring-boot version to 2.6.1 #25626

Merged
merged 19 commits into from
Dec 7, 2021
Merged

Upgrade spring-boot version to 2.6.1 #25626

merged 19 commits into from
Dec 7, 2021

Conversation

Netyyyy
Copy link
Member

@Netyyyy Netyyyy commented Nov 23, 2021 •
edited
Loading

Upgrade spring-boot version from 2.5.4 to 2.6.1

@ghost ghost added the azure-spring All azure-spring related issues label Nov 23, 2021
@Netyyyy Netyyyy linked an issue Nov 23, 2021 that may be closed by this pull request
Upgrade spring boot to 2.6.1 #25581
Closed
6 tasks
@Netyyyy
Copy link
Member Author

Netyyyy commented Nov 24, 2021

Hi,@kushagraThapar
I'm updating spring-boot version to 2.6.0, when mockito-core and mockito-inline version changed from 3.12.4 to 4.0.0,
some errors appear:
image
Please help fix this error,thanks!

@kushagraThapar
Copy link
Member

@simplynaveen20 - can you please take a look at these issues?
I am assuming mockito removed one of the APIs, which we are using in cosmos, which is creating this issue.

@Netyyyy - can you please also provide all the breaking changes in mockito version 3 -> 4, so that we can analyze the scope of this change. Thanks!

@Netyyyy
Copy link
Member Author

Netyyyy commented Nov 25, 2021

@kushagraThapar - you can see all the changes in mockito version 3 -> 4 from here,they turely removed some deprecated APIs,including method verifyZeroInteractions,please fix it,thanks.

@chenrujun chenrujun changed the title [WIP]Upgrade spring-boot version to 2.6.0 Upgrade spring-boot version to 2.6.0 Nov 25, 2021
@chenrujun
Copy link

/azp run java - spring - tests

@chenrujun
Copy link

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Azure Azure deleted a comment from azure-pipelines bot Nov 25, 2021
@chenrujun
Copy link

Hi, @Netyyyy .

Could you please update this PR description and click Ready for review?

@Netyyyy Netyyyy marked this pull request as ready for review November 25, 2021 06:16
@chenrujun chenrujun mentioned this pull request Dec 3, 2021
Closed
@azure-sdk
Copy link
Collaborator

API changes have been detected in com.azure:azure-cosmos. You can review API changes here

API changes

+         requires io.netty.transport.classes.epoll;

@chenrujun
Copy link

/azp run java - keyvault - tests

@chenrujun
Copy link

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@saragluna
Copy link
Member

/azp run java - identity - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@Netyyyy
Copy link
Member Author

Netyyyy commented Dec 6, 2021

/azp run java - spring - tests

@Netyyyy
Copy link
Member Author

Netyyyy commented Dec 6, 2021

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Netyyyy
Copy link
Member Author

Netyyyy commented Dec 6, 2021

/azp run java - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - keyvault - tests

@chenrujun
Copy link

/azp run java - cosmos - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

saragluna
saragluna approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Netyyyy Netyyyy merged commit e18d6e0 into Azure:main Dec 7, 2021
@Netyyyy Netyyyy mentioned this pull request Dec 8, 2021
Merged
@chenrujun chenrujun mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weidongxu-microsoft weidongxu-microsoft weidongxu-microsoft left review comments

@saragluna saragluna saragluna approved these changes

@aayush3011 aayush3011 Awaiting requested review from aayush3011

@abhipsaMisra abhipsaMisra Awaiting requested review from abhipsaMisra abhipsaMisra is a code owner

@AlonsoMondal AlonsoMondal Awaiting requested review from AlonsoMondal

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft alzimmermsft is a code owner

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@anjbur anjbur Awaiting requested review from anjbur

@ankitarorabit ankitarorabit Awaiting requested review from ankitarorabit ankitarorabit is a code owner

@anuchandy anuchandy Awaiting requested review from anuchandy anuchandy is a code owner

@arifibrahim4 arifibrahim4 Awaiting requested review from arifibrahim4

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978 ArthurMa1978 is a code owner

@azabbasi azabbasi Awaiting requested review from azabbasi

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@billwert billwert Awaiting requested review from billwert billwert is a code owner

@chenrujun chenrujun Awaiting requested review from chenrujun

@conniey conniey Awaiting requested review from conniey conniey is a code owner

@craigktreasure craigktreasure Awaiting requested review from craigktreasure

@danielav7 danielav7 Awaiting requested review from danielav7 danielav7 is a code owner

@digimaun digimaun Awaiting requested review from digimaun digimaun is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@drwill-ms drwill-ms Awaiting requested review from drwill-ms

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel

@g2vinay g2vinay Awaiting requested review from g2vinay g2vinay is a code owner

@gingi gingi Awaiting requested review from gingi

@guenp guenp Awaiting requested review from guenp

@haolingdong-msft haolingdong-msft Awaiting requested review from haolingdong-msft haolingdong-msft is a code owner

@hui1110 hui1110 Awaiting requested review from hui1110

@JamesBirdsall JamesBirdsall Awaiting requested review from JamesBirdsall

@jaschrep-msft jaschrep-msft Awaiting requested review from jaschrep-msft

@jialigit jialigit Awaiting requested review from jialigit

@JianpingChen JianpingChen Awaiting requested review from JianpingChen

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles JonathanGiles is a code owner

@joshfree joshfree Awaiting requested review from joshfree joshfree is a code owner

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@ki1729 ki1729 Awaiting requested review from ki1729

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@kryalama kryalama Awaiting requested review from kryalama

@kushagraThapar kushagraThapar Awaiting requested review from kushagraThapar

@LarryOsterman LarryOsterman Awaiting requested review from LarryOsterman LarryOsterman is a code owner

@lmolkova lmolkova Awaiting requested review from lmolkova lmolkova is a code owner

@MalcolmTyrrell MalcolmTyrrell Awaiting requested review from MalcolmTyrrell

@mbhaskar mbhaskar Awaiting requested review from mbhaskar

@milismsft milismsft Awaiting requested review from milismsft

@minnieliu minnieliu Awaiting requested review from minnieliu minnieliu is a code owner

@moarychan moarychan Awaiting requested review from moarychan moarychan is a code owner

@moderakh moderakh Awaiting requested review from moderakh

@mrm9084 mrm9084 Awaiting requested review from mrm9084

@mssfang mssfang Awaiting requested review from mssfang mssfang is a code owner

@pallavit pallavit Awaiting requested review from pallavit

@paterasMSFT paterasMSFT Awaiting requested review from paterasMSFT

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

@ricardo-espinoza ricardo-espinoza Awaiting requested review from ricardo-espinoza

@rickle-msft rickle-msft Awaiting requested review from rickle-msft

@RoyHerrod RoyHerrod Awaiting requested review from RoyHerrod

@samvaity samvaity Awaiting requested review from samvaity samvaity is a code owner

@schaabs schaabs Awaiting requested review from schaabs

@simplynaveen20 simplynaveen20 Awaiting requested review from simplynaveen20

@sjkwak sjkwak Awaiting requested review from sjkwak sjkwak is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@stliu stliu Awaiting requested review from stliu

@timtay-microsoft timtay-microsoft Awaiting requested review from timtay-microsoft timtay-microsoft is a code owner

@trask trask Awaiting requested review from trask trask is a code owner

@vcolin7 vcolin7 Awaiting requested review from vcolin7 vcolin7 is a code owner

@vxfield vxfield Awaiting requested review from vxfield vxfield is a code owner

@whisper6284 whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

@XiaofeiCao XiaofeiCao Awaiting requested review from XiaofeiCao XiaofeiCao is a code owner

@xinlian12 xinlian12 Awaiting requested review from xinlian12

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

@bganapa bganapa Awaiting requested review from bganapa bganapa is a code owner

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade spring-boot to 2.6.1, and upgrade external dependencies Upgrade spring boot to 2.6.1
8 participants
@Netyyyy @kushagraThapar @chenrujun @weidongxu-microsoft @vcolin7 @xinlian12 @azure-sdk @saragluna