Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add azure-resourcemanager into azure-sdk-bom. #24464

Conversation

chenrujun
Copy link

Fix #24460

@chenrujun chenrujun added Client This issue points to a problem in the data-plane of the library. azure-spring All azure-spring related issues labels Sep 30, 2021
@chenrujun chenrujun self-assigned this Sep 30, 2021
@ghost ghost added the Azure.Core azure-core label Sep 30, 2021
@chenrujun chenrujun added this to the [2021] November milestone Sep 30, 2021
@chenrujun
Copy link
Author

Hi, @alzimmermsft , could you please help to review this PR?

@chenrujun
Copy link
Author

Hi, @pallavit , could you please help to review this PR?

@pallavit
Copy link
Contributor

@chenrujun azure-sdk-bom is meant to be a client SDK BOM, so control plane libraries should not be part of this BOM. What scenario are we trying to address here?

Copy link
Contributor

@pallavit pallavit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's understand why we need control plane dependencies in data plane BOM.

@chenrujun
Copy link
Author

@pallavit ,

Thank you for telling me that azure-sdk-bom is data plane bom.
I still have 2 questions:

  1. Can azure-sdk-bom be both data plane and control plane bom?
  2. If azure-sdk-bom is only for data plane, do we have a bom for control plane?

@pallavit
Copy link
Contributor

pallavit commented Oct 12, 2021

@pallavit ,

Thank you for telling me that azure-sdk-bom is data plane bom. I still have 2 questions:

  1. Can azure-sdk-bom be both data plane and control plane bom?
  2. If azure-sdk-bom is only for data plane, do we have a bom for control plane?

azure-sdk-bom is the BOM for client libraries. I wish naming could have been more explicit. I also think we should have a separate BOM for the control plane libraries, it is something we have not gotten to yet. I am curious why you need this dependency in the BOM, knowing the scenario may help expediate the creation of the control plane BOM or a more targeted update to address things.

@chenrujun
Copy link
Author

chenrujun commented Oct 13, 2021

I am curious why you need this dependency in the BOM,

I want to delete azure-resourcemanager's version in azure-spring-cloud-dependencies:

<!--Azure SDK-->
<dependency>
<groupId>com.azure.resourcemanager</groupId>
<artifactId>azure-resourcemanager</artifactId>
<version>${azure.resourcemanager.version}</version>
</dependency>

Because azure-spring-cloud-dependencies already imported azure-sdk-bom:

<dependencyManagement>
<dependencies>
<dependency>
<groupId>com.azure</groupId>
<artifactId>azure-sdk-bom</artifactId>
<version>1.0.4</version>
<type>pom</type>
<scope>import</scope>
</dependency>

azure-resourcemanager is a part of sdk, so its version should put in azure-sdk-bom instead of azure-spring-cloud-dependencies.

@chenrujun
Copy link
Author

Closing this PR because azure-resourcemanager belong to control plane, now we do not have bom for control plane libraries.

@chenrujun chenrujun closed this Oct 15, 2021
@chenrujun chenrujun deleted the add-azure-resource-manager-into-azure-sdk-bom branch October 15, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core azure-spring All azure-spring related issues Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add azure-resourcemanager into azure-sdk-bom
3 participants