-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add azure-resourcemanager into azure-sdk-bom. #24464
Add azure-resourcemanager into azure-sdk-bom. #24464
Conversation
Hi, @alzimmermsft , could you please help to review this PR? |
Hi, @pallavit , could you please help to review this PR? |
@chenrujun azure-sdk-bom is meant to be a client SDK BOM, so control plane libraries should not be part of this BOM. What scenario are we trying to address here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's understand why we need control plane dependencies in data plane BOM.
Thank you for telling me that azure-sdk-bom is data plane bom.
|
azure-sdk-bom is the BOM for client libraries. I wish naming could have been more explicit. I also think we should have a separate BOM for the control plane libraries, it is something we have not gotten to yet. I am curious why you need this dependency in the BOM, knowing the scenario may help expediate the creation of the control plane BOM or a more targeted update to address things. |
I want to delete azure-resourcemanager's version in azure-spring-cloud-dependencies: azure-sdk-for-java/sdk/boms/azure-spring-cloud-dependencies/pom.xml Lines 166 to 171 in 5fd44e7
Because azure-spring-cloud-dependencies already imported azure-sdk-bom: azure-sdk-for-java/sdk/boms/azure-spring-cloud-dependencies/pom.xml Lines 52 to 60 in 5fd44e7
azure-resourcemanager is a part of sdk, so its version should put in azure-sdk-bom instead of azure-spring-cloud-dependencies. |
Closing this PR because azure-resourcemanager belong to control plane, now we do not have bom for control plane libraries. |
Fix #24460