Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API consistency review updates #24130

Merged
merged 5 commits into from
Sep 16, 2021
Merged

API consistency review updates #24130

merged 5 commits into from
Sep 16, 2021

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Sep 14, 2021

This PR updates Azure Monitor Query APIs to address some arch board feedback and to be consistent across other languages.

Fixes #22547

@srnagar srnagar requested a review from pallavit as a code owner September 14, 2021 20:29
@srnagar srnagar self-assigned this Sep 14, 2021
@srnagar srnagar added Monitor - Query Client This issue points to a problem in the data-plane of the library. labels Sep 14, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@srnagar
Copy link
Member Author

srnagar commented Sep 15, 2021

/azp run java - monitor - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@srnagar srnagar enabled auto-merge (squash) September 16, 2021 19:33
@srnagar srnagar merged commit 990d528 into Azure:main Sep 16, 2021
srnagar added a commit to srnagar/azure-sdk-for-java that referenced this pull request Sep 20, 2021
* API consistency review updates

* update type names

* revert experimental changes

* Fix codesnippet name
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Jun 2, 2023
Added Azure API Center resource manager. (Azure#24130)

* Added Azure API Center resource manager.

* Added managed identity properties. Changed top-level resource type.

---------

Co-authored-by: Alexander Zaslonov <[email protected]>
@srnagar srnagar added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Monitor Query Samples, Quickstarts, and Documentation based on final consistency review
2 participants