Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgmt, exclude arc sites from appservice #23813

Conversation

weidongxu-microsoft
Copy link
Member

<style> </style>

Hi,

  The app kinds you will see for App Service/Functions/Logic Apps on Kubernetes with Arc are:

 

Type of App Kind
Web App (Code) app,linux,kubernetes
Web App (Container) app,linux,container,kubernetes
Function app (Code) functionapp,linux,kubernetes
Function app (Container functionapp,linux,container,kubernetes
Logic app (Code) functionapp,linux,workflowapp,kubernetes
Logic app (Container) functionapp,linux,container,workflowapp,kubernetes

List<String> kinds = Arrays.asList(inner.kind().split(","));
if (kinds.contains("app") || kinds.contains("api")) {
List<String> kinds = Arrays.asList(inner.kind().split(Pattern.quote(",")));
if ((kinds.contains("app") || kinds.contains("api")) && !kinds.contains("kubernetes")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to have enum/constants to represent kinds value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently they do not have a shared parent to put the constant, and it seems not worthwhile to make a new class for constant, as currently here is only 1 "kubernetes" duplicated in 2 places.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it's fine for now.

@weidongxu-microsoft weidongxu-microsoft merged commit 9c9628b into Azure:main Aug 31, 2021
@weidongxu-microsoft weidongxu-microsoft deleted the mgmt_appservice-exclude-arc branch August 31, 2021 02:30
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Oct 12, 2023
Microsoft.KeyVault 2023-07-01 Add changes for Trusted Access Mode (Azure#23813)

* Adds base for updating Microsoft.KeyVault from version stable/2023-02-01 to version 2023-07-01

* Updates readme

* Updates API version in new specs and examples

* Add Identity to managed HSM resources

* Remove ManagedHsmIdentityTargetResource

* use common type for Identity

* Update identity definition

* Update readme.python.md

* Update readme.python.md

---------

Co-authored-by: Yuchao Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants