Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more configuration items for resource server #23291

Merged
merged 4 commits into from
Aug 4, 2021
Merged

Add more configuration items for resource server #23291

merged 4 commits into from
Aug 4, 2021

Conversation

chenrujun
Copy link

Add more configuration items for resource server

rujche added 3 commits August 2, 2021 11:00
@rujche
1. Add more configuration items for resource-server:
8c3a578 
1.1. azure.activedirectory.resource-server.principal-claim-name=fake-claim-name.
1.2. azure.activedirectory.resource-server.claim-to-authority-prefix-map.fake-key-1=fake-value-1
2. Add new package to put instances: com.azure.spring.aad.implementation.constants
@rujche
Update change log for the 2 new configuration item.
d52e1ed
@rujche
Update java doc and README.md
e69e941
@ghost ghost added the azure-spring All azure-spring related issues label Aug 2, 2021
@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun chenrujun added this to the [2021] September milestone Aug 2, 2021
@chenrujun chenrujun linked an issue Aug 2, 2021 that may be closed by this pull request
[FEATURE REQ] Add more configuration items for resource-server #21005
Closed
@chenrujun
Copy link
Author

/azp run java - spring - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chenrujun
Copy link
Author

Hi, @moarychan , @yiliuTo , @zhichengliu12581 , please help to review this PR.

chenrujun
chenrujun commented Aug 2, 2021
View reviewed changes
...azure-spring-boot/src/main/java/com/azure/spring/aad/webapi/AADResourceServerProperties.java
/**
* Configuration properties for Azure Active Directory B2C.
*/
@ConfigurationProperties("azure.activedirectory.resource-server")
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yiliuTo , maybe should should use the new property prefix? Or support both new and old property prefix at the same time.

@chenrujun chenrujun self-assigned this Aug 2, 2021
@moarychan
Copy link
Member

Hi @chenrujun , is it possible to apply this feature to the b2c starter at the same time?

@chenrujun
Copy link
Author

chenrujun commented Aug 3, 2021 •
edited
Loading

@moarychan ,

is it possible to apply this feature to the b2c starter at the same time?

Good point, I'll do it in another PR.
Since current PR's integration test has already passed.
It's better to make PR small.

@chenrujun
Copy link
Author

Hi, @moarychan , @yiliuTo , @zhichengliu12581 .
Please help to review this PR.
And comment LGTM if you think it's OK to merge.

@moarychan
Copy link
Member

LGYM.

@zhichengliu12581
Copy link
Contributor

LGTM

yiliuTo
yiliuTo approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@yiliuTo yiliuTo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrujun chenrujun merged commit 190462f into Azure:main Aug 4, 2021
@chenrujun chenrujun deleted the add-more-configuration-items-for-resource-server branch August 4, 2021 01:22
@chenrujun
Copy link
Author

After discuss with @moarychan , we think that we do not need such kind of property, because current AADB2CJwtBearerTokenAuthenticationConverter only used in test code and sample code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiliuTo yiliuTo yiliuTo approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@saragluna saragluna Awaiting requested review from saragluna saragluna is a code owner

@stliu stliu Awaiting requested review from stliu

Assignees

@chenrujun chenrujun

Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
[2021] September
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Add more configuration items for resource-server
5 participants
@chenrujun @moarychan @zhichengliu12581 @yiliuTo @rujche