Fixing serialisation warning on clientSideRequestDiagnostics #23086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplynaveen20
requested review from
aayush3011,
FabianMeiswinkel,
kirankumarkolli,
kushagraThapar,
mbhaskar,
milismsft,
moderakh and
xinlian12
as code owners
ghost
added
the
moderakh
approved these changes
Jul 20, 2021
There was a problem hiding this comment.
LGTM. we should use a different ObjectMapper than then one with AfterBurner which is used for data payload serialization for diagnostics serialization. Please check if we are using the same ObjectMapper or different.
see this PR for more context:
https://github.com/Azure/azure-sdk-for-java/pull/20114/files
also if possible for internal types and diagnostics we should rely on customer serializer rather than the ObjectMapper auto discovery of the class structure. see this as example:
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/routing/PartitionKeyInternal.java#L35-L36
simplynaveen20
changed the title
kushagraThapar
requested changes
Jul 20, 2021
…ew mapper for tracer/feedDiagnostics/cosmospageflux
simplynaveen20
changed the title
kushagraThapar
approved these changes
Jul 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue -
After burner will throw waring which serialization of package private fields
In ClientSideStatistics class we had some fields which is getting serialized as package private.
Also SystemInfomation was not visible to jackson.
Note: This is only repro on jar which is published to central repo and not the local jar. Will test it on Azure repo before publishing it to maven.
closes #22974