Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AzMon Trace Exporter support for EventHubs #21668

Merged
merged 9 commits into from
Aug 12, 2021

Conversation

trask
Copy link
Member

@trask trask commented May 20, 2021

The exporter needs to apply messaging semantic conventions to EventHubs spans.

Ideally EventHubs SDK should conform to the messaging semantic conventions, but no rush as those are still not finalized and may still change.

@trask trask requested review from joshfree and srnagar as code owners May 20, 2021 00:07
@trask trask marked this pull request as draft May 20, 2021 00:18
@trask trask marked this pull request as ready for review May 20, 2021 15:58
@trask trask requested a review from srnagar May 27, 2021 22:47
@joshfree joshfree assigned lmolkova and unassigned srnagar Aug 9, 2021
@joshfree
Copy link
Member

joshfree commented Aug 9, 2021

@lmolkova could you help shepherd this change in?

@trask trask requested review from lmolkova and samvaity as code owners August 9, 2021 21:52
@lmolkova
Copy link
Member

lmolkova commented Aug 9, 2021

Based on later discussions, we're going to stick to the current spec until we update messaging OTel conventions to support EventHubs scenarios - we're working on it with AzMon team.
We're making the current spec more official and adding mappings to common-schema. This is a temporary solution and we'll be converging to OTel conventions once they mature - this is also across 4 languages.

The concern here is that OTel conventions are experimental and might change and we'd have to diverge or follow them.

Sorry, not related to this PR.

Copy link
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about request telemetry support? https://gist.github.com/lmolkova/e4215c0f44a49ef824983382762e6b92#file-z_azure_monitor_exporter_mapping-md

It was important for some portal experiences.
[edit] : i guess customMeasurements["timeSinceEnqueued"] is irrelevant without metrics support, but source is still useful - it allows consumer to now which EventHubs it interacted with

@trask
Copy link
Member Author

trask commented Aug 11, 2021

What about request telemetry support? https://gist.github.com/lmolkova/e4215c0f44a49ef824983382762e6b92#file-z_azure_monitor_exporter_mapping-md

It was important for some portal experiences.
[edit] : i guess customMeasurements["timeSinceEnqueued"] is irrelevant without metrics support, but source is still useful - it allows consumer to now which EventHubs it interacted with

oh nice! this is done now


// special case needed until Azure SDK moves to OTel semantic conventions
private static void applyServiceBusSpan(Attributes attributes, RemoteDependencyData telemetry) {
telemetry.setType("AZURE SERVICE BUS");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why EventHubs is Microsoft.EventHub and Service Bus is AZURE SERVICE BUS ? I belive they are different generations of telemetry types, just wonder if ServiceBus can also move to Azure resource provider namespace

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, i'll raise this with U/X team to support Microsoft.ServiceBus 👍

@trask trask merged commit ee858a3 into Azure:main Aug 12, 2021
@trask trask deleted the better-eventhubs-support branch August 12, 2021 17:21
@srnagar srnagar added OpenTelemetry OpenTelemetry instrumentation and removed azmonexp labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants