-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AzMon Trace Exporter support for EventHubs #21668
Conversation
...porter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorTraceExporter.java
Outdated
Show resolved
Hide resolved
...porter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorTraceExporter.java
Outdated
Show resolved
Hide resolved
@lmolkova could you help shepherd this change in? |
Sorry, not related to this PR. |
...porter/src/main/java/com/azure/monitor/opentelemetry/exporter/AzureMonitorTraceExporter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about request telemetry support? https://gist.github.com/lmolkova/e4215c0f44a49ef824983382762e6b92#file-z_azure_monitor_exporter_mapping-md
It was important for some portal experiences.
[edit] : i guess customMeasurements["timeSinceEnqueued"]
is irrelevant without metrics support, but source
is still useful - it allows consumer to now which EventHubs it interacted with
oh nice! this is done now |
|
||
// special case needed until Azure SDK moves to OTel semantic conventions | ||
private static void applyServiceBusSpan(Attributes attributes, RemoteDependencyData telemetry) { | ||
telemetry.setType("AZURE SERVICE BUS"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why EventHubs is Microsoft.EventHub
and Service Bus is AZURE SERVICE BUS
? I belive they are different generations of telemetry types, just wonder if ServiceBus can also move to Azure resource provider namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya, i'll raise this with U/X team to support Microsoft.ServiceBus
👍
The exporter needs to apply messaging semantic conventions to EventHubs spans.
Ideally EventHubs SDK should conform to the messaging semantic conventions, but no rush as those are still not finalized and may still change.