-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] Tests - common naming - shares. #21182
Conversation
@@ -276,7 +276,6 @@ class FileServiceAPITests extends APISpec { | |||
FileTestHelper.assertFileServicePropertiesAreEqual(updatedProperties, getPropertiesAfterResponse.getValue()) | |||
} | |||
|
|||
@Requires( { playbackMode() } ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this disturbing.
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
|
||
shareClient.deleteWithResponse(new ShareDeleteOptions().setDeleteSnapshotsOptions(ShareSnapshotsDeleteOptionType.INCLUDE), null, null) | ||
def cleanupFileServiceClient = new ShareServiceClientBuilder() | ||
.connectionString(connectionString) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add the retry options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's exponential retry by default. what was here before was causing 5xx timeouts...
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run java - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/check-enforcer override |
Disable purge protection in examples (Azure#21182) * Update ManagedHsm_CreateOrUpdate.json * Update ManagedHsm_Get.json * Update ManagedHsm_Update.json * disable purge protection in examples
No description provided.