Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Tests - common naming - shares. #21182

Merged
merged 7 commits into from
May 5, 2021

Conversation

kasobol-msft
Copy link
Contributor

No description provided.

@kasobol-msft kasobol-msft requested a review from gapra-msft May 5, 2021 20:39
@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label May 5, 2021
@kasobol-msft kasobol-msft requested a review from alzimmermsft May 5, 2021 20:40
@@ -276,7 +276,6 @@ class FileServiceAPITests extends APISpec {
FileTestHelper.assertFileServicePropertiesAreEqual(updatedProperties, getPropertiesAfterResponse.getValue())
}

@Requires( { playbackMode() } )
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this disturbing.

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).


shareClient.deleteWithResponse(new ShareDeleteOptions().setDeleteSnapshotsOptions(ShareSnapshotsDeleteOptionType.INCLUDE), null, null)
def cleanupFileServiceClient = new ShareServiceClientBuilder()
.connectionString(connectionString)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add the retry options?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's exponential retry by default. what was here before was causing 5xx timeouts...

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/azp run java - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft
Copy link
Contributor Author

/check-enforcer override

@kasobol-msft kasobol-msft marked this pull request as ready for review May 5, 2021 22:32
@kasobol-msft kasobol-msft requested a review from rickle-msft as a code owner May 5, 2021 22:32
@kasobol-msft kasobol-msft merged commit 153351f into Azure:master May 5, 2021
@kasobol-msft kasobol-msft deleted the common-naming-files branch May 5, 2021 22:32
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Oct 24, 2022
Disable purge protection in examples (Azure#21182)

* Update ManagedHsm_CreateOrUpdate.json

* Update ManagedHsm_Get.json

* Update ManagedHsm_Update.json

* disable purge protection in examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants