Avoid group configuration in id_token when using appRoles #20733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiliuTo
requested review from
backwind1233,
chenrujun,
jialindai,
saragluna and
stliu
as code owners
ghost
added
the
chenrujun
reviewed
Apr 19, 2021
| "name": "groups", | ||
| "additionalProperties": ["emit_as_roles"] | ||
| }] | ||
| } |
There was a problem hiding this comment.
@backwind1233
FYI: Maybe you can use this feature when you developing this feature: #20218
benbp
pushed a commit
that referenced
this pull request
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in issue, when group attributes are configured for roles claim, then appRoles will be overrided. Thus we add declaration for this.
Here is the related official doc from Azure Active Directory.