Correct Sample README Product slug #20679
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ languages: | |
| - java | ||
| products: | ||
| - azure | ||
| - azure-event-hubs | ||
|
There was a problem hiding this comment. Why is schema registry using event hubs tag? There was a problem hiding this comment. schema registry isn't a listed product in Taxonomy Service so the doc generation has an error. schema registry is a sub-service of event hubs so I use this closest parent. If I'm wrong, we can use the root "azure". There was a problem hiding this comment. As per offline discussion, schema registry isn't a sub service of eventhubs. Use "azure" for now until schema-registry itself is listed. There was a problem hiding this comment. It may not be, but that doesn't mean it's not related. These are slugs for where customers should see the sample, so if it's related, use the slug. These aren't categorizations of the sample, but a list of related products. |
||
| urlFragment: schemaregistry-avro-samples | ||
| --- | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not azure-event-hubs since it's related? It's not like this ties the sample to that, but shows up in more places. It's just a list of what's related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @srnagar @lilyjma. what do you think of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other languages have also already used this slug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll change to event-hubs to align with other languages. We can change it later if we have a new guideline.