Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 1555 #20676

Merged
merged 2 commits into from
Apr 15, 2021

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1555 See eng/common workflow

@azure-sdk azure-sdk requested a review from heaths April 14, 2021 22:04
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Apr 14, 2021
@heaths
Copy link
Member

heaths commented Apr 15, 2021

Ran dir sdk -filter *.md -recurse | .\eng\common\scripts\Test-SampleMetadata.ps1 -AllowParentProducts and found a few errors, including a case with the script I hadn't considered:


�[91mInvalidOperation: �[0mC:\src\azure-sdk-for-java\eng\common\scripts\Test-SampleMetadata.ps1:34
�[96mLine |
�[96m  34 | �[0m         if (�[96m!$content[0].StartsWith('---')�[0m) {
�[96m     | �[91m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[91m�[96m     | �[91mCannot index into a null array.
�[0m

�[91mInvalidOperation: �[0mC:\src\azure-sdk-for-java\eng\common\scripts\Test-SampleMetadata.ps1:44
�[96mLine |
�[96m  44 | �[0m             �[96m[string] $line = $content[$i++]�[0m
�[96m     | �[91m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[91m�[96m     | �[91mCannot index into a null array.
�[0m

�[91mInvalidOperation: �[0mC:\src\azure-sdk-for-java\eng\common\scripts\Test-SampleMetadata.ps1:34
�[96mLine |
�[96m  34 | �[0m         if (�[96m!$content[0].StartsWith('---')�[0m) {
�[96m     | �[91m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[91m�[96m     | �[91mCannot index into a null array.
�[0m

�[91mInvalidOperation: �[0mC:\src\azure-sdk-for-java\eng\common\scripts\Test-SampleMetadata.ps1:44
�[96mLine |
�[96m  44 | �[0m             �[96m[string] $line = $content[$i++]�[0m
�[96m     | �[91m             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
�[91m�[96m     | �[91mCannot index into a null array.
�[0m

�[91mWrite-Error: �[91mFile 'C:\src\azure-sdk-for-java\sdk\monitor\azure-monitor-opentelemetry-exporter\src\samples\README.md' contains invalid product slug: azure-monitor-opentelemetry-exporter�[0m

�[91mWrite-Error: �[91mFile 'C:\src\azure-sdk-for-java\sdk\schemaregistry\azure-data-schemaregistry\src\samples\README.md' contains invalid product slug: azure-data-schemaregistry�[0m

�[91mWrite-Error: �[91mFile 'C:\src\azure-sdk-for-java\sdk\schemaregistry\azure-data-schemaregistry-avro\src\samples\README.md' contains invalid product slug: azure-data-schemaregistry-avro�[0m

�[91mWrite-Error: �[91mFile 'C:\src\azure-sdk-for-java\sdk\search\azure-search-documents\src\samples\README.md' contains invalid product slug: azure-search-documents�[0m

�[91mWrite-Error: �[91mFile 'C:\src\azure-sdk-for-java\sdk\spring\azure-spring-boot-samples\azure-spring-boot-sample-active-directory-resource-server-by-filter\README.md' contains invalid product slug: java�[0m

�[91mWrite-Error: �[91mFile 'C:\src\azure-sdk-for-java\sdk\storage\azure-storage-file-share\src\samples\README.md' contains invalid product slug: azure-file�[0m

�[91mWrite-Error: �[91mFile 'C:\src\azure-sdk-for-java\sdk\tables\azure-data-tables\src\samples\README.md' contains invalid product slug: azure-tables�[0m

As such, I'm not going to hook up the validation until the script is fixed.

@azure-sdk azure-sdk merged commit 29c0a06 into master Apr 15, 2021
@azure-sdk azure-sdk deleted the sync-eng/common-validate-samples-1555 branch April 15, 2021 00:56
benbp pushed a commit that referenced this pull request Apr 28, 2021
* Verify samples during CIs

Replaces Azure/azure-sdk-for-python#17999 for use in all language repos.

* Move exit to proper scope

Co-authored-by: Heath Stewart <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants