Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating Handlers and Reactor logic to Track 1 #20221

Merged
merged 23 commits into from
Mar 31, 2021
Merged

Updating Handlers and Reactor logic to Track 1 #20221

merged 23 commits into from
Mar 31, 2021

Conversation

conniey
Copy link
Member

@conniey conniey commented Mar 30, 2021 •
edited
Loading

Minimises the amount of churn in parent PR #19924.

  • Use isDequeueing in ReactorDispatcher so only one thread is dequeueing messages at a time.
  • Fixing NPE in ConnectionHandler when connection is null
  • Emitting EndpointState.CLOSED when a link is closed because the replay latestOrDefault will replay the last status (ie. "ACTIVE" then complete) when it is resubscribed to. This leads the client to believe it is connected again when it is actually closed.
  • When Authorization Token fails, the corresponding sender/receiver are disposed. (This allows the connection to create another one, if need be.)
  • Adds tests.

Related bug #19698

conniey added 12 commits March 29, 2021 16:49
@ghost ghost added the Azure.Core azure-core label Mar 30, 2021
@conniey
Copy link
Member Author

conniey commented Mar 30, 2021

/azp run java - eventhubs - tests

@conniey
Copy link
Member Author

conniey commented Mar 30, 2021

/azp run java - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey conniey force-pushed the messaging-factory branch from 62412ef to fd27a64 Compare March 30, 2021 15:23
@conniey
Copy link
Member Author

conniey commented Mar 30, 2021

/azp run java - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@conniey
Copy link
Member Author

conniey commented Mar 30, 2021

/azp run java - servicebus - tests

@conniey
Copy link
Member Author

conniey commented Mar 30, 2021

/azp run java - eventhubs - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

srnagar
srnagar approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@conniey conniey enabled auto-merge (squash) March 30, 2021 21:17
@conniey
Copy link
Member Author

conniey commented Mar 31, 2021

/check-enforcer override

@conniey conniey merged commit 233c0f7 into Azure:master Mar 31, 2021
@conniey conniey deleted the messaging-factory branch March 31, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srnagar srnagar srnagar approved these changes

@alzimmermsft alzimmermsft Awaiting requested review from alzimmermsft

@anuchandy anuchandy Awaiting requested review from anuchandy

@hemanttanwar hemanttanwar Awaiting requested review from hemanttanwar

@jianghaolu jianghaolu Awaiting requested review from jianghaolu

@mssfang mssfang Awaiting requested review from mssfang

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

@yvgopal yvgopal Awaiting requested review from yvgopal

Assignees
No one assigned
Labels
Azure.Core azure-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conniey @srnagar