Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually return the "Response" from "BlobClient.uploadWithResponse(options,content)" #20091

Closed
wants to merge 2 commits into from
Closed

Actually return the "Response" from "BlobClient.uploadWithResponse(options,content)" #20091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d2c153
Actually return the "Response" from "BlobClient.uploadWithResponse(op…
the-codinator Mar 24, 2021
ba7e924
Update javadoc
the-codinator Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sdk/storage/azure-storage-blob/src/main/java/com/azure/storage/blob/BlobClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,12 +219,13 @@ public void upload(BinaryData data, boolean overwrite) {
* @param requestConditions {@link BlobRequestConditions}
* @param timeout An optional timeout value beyond which a {@link RuntimeException} will be raised.
* @param context Additional context that is passed through the Http pipeline during the service call.
* @return Information about the uploaded block blob.
*/
@ServiceMethod(returns = ReturnType.SINGLE)
public void uploadWithResponse(InputStream data, long length, ParallelTransferOptions parallelTransferOptions,
public Response<BlockBlobItem> uploadWithResponse(InputStream data, long length, ParallelTransferOptions parallelTransferOptions,
BlobHttpHeaders headers, Map<String, String> metadata, AccessTier tier, BlobRequestConditions requestConditions,
Duration timeout, Context context) {
this.uploadWithResponse(new BlobParallelUploadOptions(data, length)
return this.uploadWithResponse(new BlobParallelUploadOptions(data, length)
.setParallelTransferOptions(parallelTransferOptions).setHeaders(headers).setMetadata(metadata).setTier(tier)
.setRequestConditions(requestConditions), timeout, context);
}
Expand Down