Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reference to unified env checklist file of spring module #19842

Merged
merged 5 commits into from
Mar 18, 2021
Merged

Reference to unified env checklist file of spring module #19842

merged 5 commits into from
Mar 18, 2021

Conversation

moarychan
Copy link
Member

Issue
project compilation failure #19752

[Update]
Reduce the scope of the maven command execution, avoid building projects other than spring module.

@ghost ghost added the azure-spring All azure-spring related issues label Mar 15, 2021
saragluna
saragluna requested changes Mar 16, 2021
View reviewed changes
sdk/spring/azure-spring-boot-samples/README.md Outdated
3. Build the whole product by executing the following command which may take several minutes
3. Build modules

1. Build all modules under the `spring` module by executing the following command which may take several minutes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we remove this section since it will fail when the dependencies are not built on the local machine, such as EH sdk.

sdk/spring/azure-spring-boot-samples/README.md Outdated
2. Only build the modules associated with the current module, such as `azure-spring-boot-sample-active-directory-webapp`.

```
mvn clean install -pl .\sdk\spring\azure-spring-boot-samples\azure-spring-boot-sample-active-directory-webapp\ -am -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true -Drevapi.skip=true -Djacoco.skip=true -DskipTests -Dparallel-test-playback
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about we remove these

-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true -Drevapi.skip=true -Djacoco.skip=true -DskipTests -Dparallel-test-playback

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can build without this and shorten the length and decrease the complexity of the command.

chenrujun
chenrujun suggested changes Mar 17, 2021
View reviewed changes
sdk/spring/azure-spring-boot-samples/README.md Outdated
```
If you want to build faster, you can append the following Maven parameters.
```
-Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true -Drevapi.skip=true -Djacoco.skip=true -DskipTests -Dparallel-test-playback
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can use this file instead?
https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/spring/build-developing-version-artifacts-if-needed.md

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs: https://github.com/Azure/azure-sdk-for-java/tree/master/sdk/spring/azure-spring-boot-starter-active-directory#prerequisites

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@moarychan moarychan changed the title Update maven building command for spring samples Reference to unified env checklist file of spring module Mar 17, 2021
@moarychan
Copy link
Member Author

Hi @chenrujun @saragluna please help to review, thanks.

saragluna
saragluna approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@saragluna saragluna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

chenrujun
chenrujun approved these changes Mar 18, 2021
View reviewed changes
Copy link

@chenrujun chenrujun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@saragluna saragluna merged commit 32b92c3 into Azure:master Mar 18, 2021
@moarychan moarychan deleted the issue/fix-scope-mvn-cmd-execution branch April 22, 2021 06:59
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
@forteddyt @teochaban
@srivatsasinha @jloeffler7 @debuggerXi @ZhidaLiu
CodeGen from PR 19842 in Azure/azure-rest-api-specs
8629596 
[Hub Generated] Review request for Microsoft.MachineLearningServices to add version preview/2022-06-01-preview (Azure#19842)

* Adds base for updating Microsoft.MachineLearningServices from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add idleShutdownSetting to Compute Instances (Azure#19748)

* Added idleTimeBeforeShutdown to compute instance properties

* Added api UpdateIdleShutdownSetting

Co-authored-by: Teo Magnino Chaban <[email protected]>

* Add mfe.json 2022-06-01-preview changes (Azure#19740)

* update mfe.json with 2022-06-01-preview spec

* update go.md with preview-2022-06

* add AutoMLJob examples (initial)

* add LabelingJob examples (initial)

* add Schedule examples (initial)

* prettier

* update AutoMLJob examples

* update LabelingJob examples

* update LabelingJob examples

* prettier

* typo fixes

* add Vectorizer to custom-words.txt

* add missing

* is this a breaking change?

* Revert "update go.md with preview-2022-06"

This reverts commit b49c64ae0eb258069251c8c13085fd1e5dde56e2.

* Updating Swagger Spec for MLC for CustomServices (Azure#19781)

* Updating Swagger Spec for MLC for CustomServices

* Added Examples

* Removing update API in favor of exisiting Patch API and Fixing some Validation issues

* Fixed Pretty Issue

* Fixed Id Issue

* Changed case

* Updated Examples

* Changing Description

* Added nullable fields

* Added update APIs

* Fixing validation errors

* Fix model validation

Co-authored-by: Srivatsa Sinha <[email protected]>

* Add encryption property to workspace update parameters (Azure#19893)

* Add encryption property to workspace update parameters

Adding the ability for users to update CMK keyIdentifier property for workspace update.

* Apply prettier changes

Co-authored-by: Joshua Loeffler <[email protected]>

* Add enum value to OutputDataDeliveryMode (Azure#19964)

* add soft delete related properties (Azure#19907)

* add soft delete related properties

* resolve lint diff issue that enum name duplicaton

Co-authored-by: Xi Jin <[email protected]>

* Remove SoftDeleteEnabled. (Azure#20005)

* reorder DeploymentResourceConfiguration Definition (Azure#20057)

Co-authored-by: Teddy Todorov <[email protected]>
Co-authored-by: teochaban <[email protected]>
Co-authored-by: Teo Magnino Chaban <[email protected]>
Co-authored-by: Teddy Todorov <[email protected]>
Co-authored-by: srivatsasinha <[email protected]>
Co-authored-by: Srivatsa Sinha <[email protected]>
Co-authored-by: jloeffler7 <[email protected]>
Co-authored-by: Joshua Loeffler <[email protected]>
Co-authored-by: XI JIN <[email protected]>
Co-authored-by: Xi Jin <[email protected]>
Co-authored-by: ZhidaLiu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saragluna saragluna saragluna approved these changes

@chenrujun chenrujun chenrujun approved these changes

@stliu stliu stliu approved these changes

@backwind1233 backwind1233 Awaiting requested review from backwind1233

@jialindai jialindai Awaiting requested review from jialindai

@yiliuTo yiliuTo Awaiting requested review from yiliuTo

Assignees
No one assigned
Labels
azure-spring All azure-spring related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moarychan @stliu @chenrujun @saragluna