Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Default TestMode in CI to RECORD #19659

Merged

Conversation

alzimmermsft
Copy link
Member

This PR changes the default TestMode for tests.ymls to RECORD instead of LIVE due to a bug in the testing framework. Said bug has been resolved in #19620 but requires configuring many POMs to use an unreleased dependency when it will be released soon. Once the fix has been shipped revert the default TestMode back to LIVE.

@alzimmermsft alzimmermsft added the EngSys This issue is impacting the engineering system. label Mar 5, 2021
@alzimmermsft alzimmermsft self-assigned this Mar 5, 2021
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets please file a follow-up issue tracking the revert of this PR once the new dependency is shipped.

@alzimmermsft alzimmermsft merged commit 320da85 into Azure:master Mar 5, 2021
@alzimmermsft alzimmermsft deleted the AzEng_ChangeDefaultTestModeToRecord branch March 5, 2021 18:22
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Aug 5, 2022
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2022-05-01 (Azure#19659)

* Adds base for updating Microsoft.RecoveryServices from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Including pause resume changes

* LintDiff Fixed

* Adding additional properties and swagger correctness part

* Added instance type in PauseReplicationInput

* Prettier Check fix

* New Job property added

* JSON fix

* Spell Check fix

* Swagger correctness - InMageRcmReplicationDetails

* vCenterFqdn change revert

* Swagger Correctness issue resolved

* Breaking Change Resolved

* Added critical job property

* Added missed property

Co-authored-by: prmyaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants