Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API changes to Azure Monitor exporter #18702

Merged
merged 6 commits into from
Feb 5, 2021

Conversation

srnagar
Copy link
Member

@srnagar srnagar commented Jan 20, 2021

This PR updates the Azure Monitor Exporter APIs to add support for the following:

  • Include an option to configure the service API version when constructing the exporter instance

This change was recommended by the arch board.

@srnagar srnagar requested a review from joshfree as a code owner January 20, 2021 17:39
@srnagar srnagar requested a review from trask January 20, 2021 17:40
@trask
Copy link
Member

trask commented Feb 5, 2021

hey @srnagar, I think the preference is to not expose instrumentationKey or endpoint directly (only exposing connectionString)

@srnagar
Copy link
Member Author

srnagar commented Feb 5, 2021

@trask updated the PR to remove the instrumentation key.

…/java/com/azure/opentelemetry/exporter/azuremonitor/AzureMonitorExporterBuilder.java

Co-authored-by: Trask Stalnaker <[email protected]>
@joshfree joshfree added Client This issue points to a problem in the data-plane of the library. Monitor Exporter labels Feb 5, 2021
@joshfree
Copy link
Member

joshfree commented Feb 5, 2021

LGTM

@srnagar srnagar merged commit b41a7ab into Azure:master Feb 5, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Apr 18, 2022
Remove APIs are not ready for downstream clients (Azure#18702)
@srnagar srnagar added OpenTelemetry OpenTelemetry instrumentation and removed Monitor - Exporter labels Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants