Session timeout 404/1002 HA fixes #18594

simplynaveen20 · 2021-01-13T15:42:04Z

This PR contains below fixes.

Regional retry is not working in query Query Session time out 404/1002, we are only retrying in same region #18498
Requests are retrying twice on same region Session time out 404/100, requests are retrying twice on same region #18499
Scenario - User's multi master region preferred list (A,B,C) before this fix ,call were going A, A, B, C. It should be A, B, C, A
Single master will behave the same as before i.e. Preferred region, Master region, Preferred region
Small improvement in read item code , where retryPolicy.onBeforeSendRequest(request) were getting called twice
unnecessary, creating confusing during debugging client retry policy

check-enforcer · 2021-01-13T16:48:03Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java

moderakh

great work @simplynaveen20 thanks for leading to improve the fail over scenarios.

a few minor comments.

...azure-cosmos/src/test/java/com/azure/cosmos/implementation/SessionNotAvailableRetryTest.java

moderakh · 2021-01-13T17:33:26Z

...osmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/query/DocumentProducer.java

            return ObservableHelper.inlineIfPossibleAsObs(
                    () -> {
+                        if(finalRetryPolicy != null) {


great catch. thanks

...azure-cosmos/src/test/java/com/azure/cosmos/implementation/SessionNotAvailableRetryTest.java

FabianMeiswinkel

LGTM - except for Mo's comments about reflection usage in InternalObjectNode. once those are addressed I am good.

…improving code readablity

simplynaveen20 · 2021-01-13T20:33:08Z

/azp run java - cosmos - tests

azure-pipelines · 2021-01-13T20:33:20Z

Azure Pipelines successfully started running 1 pipeline(s).

simplynaveen20 · 2021-01-14T17:15:24Z

/azp run java - cosmos - tests

azure-pipelines · 2021-01-14T17:15:35Z

Azure Pipelines successfully started running 1 pipeline(s).

moderakh

Thank you @simplynaveen20
LGTM.

As we are planning to do a hotfix release on Friday, before merging this PR please check with @kushagraThapar whether to include this hotfix in the bugfix release or not.

as we may want to keep this change in the master branch run a few CTL before releasing it to public.

moderakh · 2021-01-14T17:26:55Z

sdk/cosmos/azure-cosmos/pom.xml

@@ -366,6 +366,27 @@ Licensed under the MIT License.
        </plugins>
      </build>
    </profile>
+    <profile>
+      <!-- integration tests, requires Cosmos DB endpoint with multi region support -->
+      <id>multi-region</id>


some of the CIs provide multi-region account to the existing test group.
Why do we need this additional test group?
also is there a specific consistency configured in the CI for the test group?

We don't have any group which runs only multi-region single master. My test need that case explicitly

simplynaveen20 · 2021-01-19T22:44:34Z

/azp run java - cosmos - tests

azure-pipelines · 2021-01-19T22:44:45Z

Azure Pipelines successfully started running 1 pipeline(s).

simplynaveen20 · 2021-01-19T23:31:40Z

/azp run java - cosmos - tests

azure-pipelines · 2021-01-19T23:31:51Z

Azure Pipelines successfully started running 1 pipeline(s).

simplynaveen20 · 2021-01-20T17:21:16Z

/azp run java - cosmos - tests

azure-pipelines · 2021-01-20T17:21:27Z

Azure Pipelines successfully started running 1 pipeline(s).

mbhaskar · 2021-01-20T18:21:21Z

/azp run java - cosmos - tests

azure-pipelines · 2021-01-20T18:21:31Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/cosmos/tests.yml

simplynaveen20 · 2021-01-20T19:32:56Z

/azp run java - cosmos - tests

azure-pipelines · 2021-01-20T19:33:08Z

Azure Pipelines successfully started running 1 pipeline(s).

benbp · 2021-01-20T19:43:26Z

tests.yml LGTM

Review request for Microsoft.ContainerService to add version 2022-03-01 (Azure#18686) * Adds base for updating Microsoft.ContainerService from version stable/2022-02-01 to version 2022-03-01 * Updates readme * Updates API version in new specs and examples * Update readmes for the 2022-03-01 dev branch of container service (Azure#18357) * update readme * update sdk readmes * feat: add ManagedCluster StorageProfile in 0301 (Azure#18594) Signed-off-by: Ji An Liu <[email protected]> * Replace common type definitions with references since 2022-03-01 for Microsoft.ContainerService (Azure#18568) * replace Resource * replacing systemData * replace parameters * fix: replace Resource with TrackedResource * replace track2 with python Co-authored-by: Ji'an Liu <[email protected]>

simplynaveen20 added 4 commits January 12, 2021 17:53

HA fixes

8598817

removing extra onBefore on read request

25ea739

incremental change in test case

303b7ec

incremental change in test case

409a819

simplynaveen20 requested review from FabianMeiswinkel, kirankumarkolli, kushagraThapar, mbhaskar, milismsft, moderakh and xinlian12 as code owners January 13, 2021 15:42

ghost added the Cosmos label Jan 13, 2021

simplynaveen20 added 2 commits January 13, 2021 11:21

ignoring warning from test case

8533948

fixing null pointer in test case on document producer

0a5597c

ealsur reviewed Jan 13, 2021

View reviewed changes

sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/implementation/ClientRetryPolicy.java Show resolved Hide resolved

moderakh reviewed Jan 13, 2021

View reviewed changes

simplynaveen20 added 3 commits January 13, 2021 12:49

adding another test case for non preferred list

a1d22da

closing clients

7602035

using reflection utils methods

e4e48b8

FabianMeiswinkel approved these changes Jan 13, 2021

View reviewed changes

adding 0th index for single master explicity to go to master region, …

b1cc2d0

…improving code readablity

ealsur approved these changes Jan 13, 2021

View reviewed changes

Removing InternalObjectNode from the test case

7245918

Adding seperate CI for multi region and single master

6a93f39

simplynaveen20 requested a review from danieljurek as a code owner January 14, 2021 17:09

moderakh approved these changes Jan 14, 2021

View reviewed changes

stopping the ci

b09e5be

benbp requested changes Jan 20, 2021

View reviewed changes

sdk/cosmos/tests.yml Outdated Show resolved Hide resolved

simplynaveen20 added 2 commits January 20, 2021 14:28

Merge branch 'latest-master' into users/nakumars/HAfixes

8333d76

merge with master and fixing new test pipeline

c665d98

simplynaveen20 requested a review from benbp January 20, 2021 19:32

benbp approved these changes Jan 20, 2021

View reviewed changes

mbhaskar merged commit 89fb1fc into Azure:master Jan 21, 2021

simplynaveen20 mentioned this pull request Jul 30, 2021

Query Session time out 404/1002, we are only retrying in same region #18498

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Session timeout 404/1002 HA fixes #18594

Session timeout 404/1002 HA fixes #18594

simplynaveen20 commented Jan 13, 2021 •

edited

Loading

check-enforcer bot commented Jan 13, 2021

moderakh left a comment

moderakh Jan 13, 2021

FabianMeiswinkel left a comment

simplynaveen20 commented Jan 13, 2021

azure-pipelines bot commented Jan 13, 2021

simplynaveen20 commented Jan 14, 2021

azure-pipelines bot commented Jan 14, 2021

moderakh left a comment

moderakh Jan 14, 2021

simplynaveen20 Jan 14, 2021

simplynaveen20 commented Jan 19, 2021

azure-pipelines bot commented Jan 19, 2021

simplynaveen20 commented Jan 19, 2021

azure-pipelines bot commented Jan 19, 2021

simplynaveen20 commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

mbhaskar commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

simplynaveen20 commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

benbp commented Jan 20, 2021

Session timeout 404/1002 HA fixes #18594

Session timeout 404/1002 HA fixes #18594

Conversation

simplynaveen20 commented Jan 13, 2021 • edited Loading

check-enforcer bot commented Jan 13, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

moderakh left a comment

Choose a reason for hiding this comment

moderakh Jan 13, 2021

Choose a reason for hiding this comment

FabianMeiswinkel left a comment

Choose a reason for hiding this comment

simplynaveen20 commented Jan 13, 2021

azure-pipelines bot commented Jan 13, 2021

simplynaveen20 commented Jan 14, 2021

azure-pipelines bot commented Jan 14, 2021

moderakh left a comment

Choose a reason for hiding this comment

moderakh Jan 14, 2021

Choose a reason for hiding this comment

simplynaveen20 Jan 14, 2021

Choose a reason for hiding this comment

simplynaveen20 commented Jan 19, 2021

azure-pipelines bot commented Jan 19, 2021

simplynaveen20 commented Jan 19, 2021

azure-pipelines bot commented Jan 19, 2021

simplynaveen20 commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

mbhaskar commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

simplynaveen20 commented Jan 20, 2021

azure-pipelines bot commented Jan 20, 2021

benbp commented Jan 20, 2021

simplynaveen20 commented Jan 13, 2021 •

edited

Loading