ServiceBus GA - API correction based on final review #17869
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on my review. But it needs to be reviewed by other team members.
Please review API View for GA release candidate.
amqp : https://apiview.dev/Assemblies/Review/5dd2fd672f794c76994ddce076eca2f6
service bus : https://apiview.dev/Assemblies/Review/6af850ed7eb04843a6897afbe13cdd28
Following are some my review comments. Pelase look into it.
ServiceBusReceivedMessage
public BinaryData getBody()
public byte[] getBodyAsBytes()
I added
getBodyAsBytes
as convenience..net does not have it.
And user can easily get bytes from BinaryData.
Remove getBodyAsBytes()
Remove
At
suffix from follwing peekMessages API..Net and other languages does not have it.
We have not discussed in long time. I feel like it is just a miss.
Mono peekMessageAt(long sequenceNumber, String sessionId)
Flux peekMessagesAt(int maxMessages, long sequenceNumber, String sessionId)
public Mono peekMessageAt(long sequenceNumber)
Mono peekMessageAt(long sequenceNumber, String sessionId)
public Mono peekMessageAt(long sequenceNumber)
Following does not have 'At' suffix.
Mono peekMessage(String sessionId)
public Mono peekMessage()
ServiceBusTransactionContext
ServiceBusSenderClient
ServiceBusAdministrationClientBuilder
CreateQueueOptions
CreateRuleOptions
CreateSubscriptionOptions
CreateTopicOptions
TopicRuntimeProperties
FalseRuleFilter
SharedAccessAuthorizationRule
@srnagar @conniey @JonathanGiles @ramya-rao-a