Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBus GA - API correction based on final review #17869

Merged

Conversation

hemanttanwar
Copy link
Contributor

@hemanttanwar hemanttanwar commented Nov 28, 2020

This is based on my review. But it needs to be reviewed by other team members.

Please review API View for GA release candidate.

amqp : https://apiview.dev/Assemblies/Review/5dd2fd672f794c76994ddce076eca2f6
service bus : https://apiview.dev/Assemblies/Review/6af850ed7eb04843a6897afbe13cdd28

Following are some my review comments. Pelase look into it.

  1. ServiceBusReceivedMessage
    public BinaryData getBody()
    public byte[] getBodyAsBytes()

    I added getBodyAsBytes as convenience.
    .net does not have it.
    And user can easily get bytes from BinaryData.

    Remove getBodyAsBytes()

  2. Remove At suffix from follwing peekMessages API.
    .Net and other languages does not have it.
    We have not discussed in long time. I feel like it is just a miss.

Mono peekMessageAt(long sequenceNumber, String sessionId)
Flux peekMessagesAt(int maxMessages, long sequenceNumber, String sessionId)
public Mono peekMessageAt(long sequenceNumber)
Mono peekMessageAt(long sequenceNumber, String sessionId)
public Mono peekMessageAt(long sequenceNumber)

Following does not have 'At' suffix.

Mono peekMessage(String sessionId)
public Mono peekMessage()

  1. Make class final
    ServiceBusTransactionContext
    ServiceBusSenderClient
    ServiceBusAdministrationClientBuilder
    CreateQueueOptions
    CreateRuleOptions
    CreateSubscriptionOptions
    CreateTopicOptions
    TopicRuntimeProperties
    FalseRuleFilter
    SharedAccessAuthorizationRule

@srnagar @conniey @JonathanGiles @ramya-rao-a

@hemanttanwar hemanttanwar self-assigned this Nov 28, 2020
@ghost ghost added the Service Bus label Nov 28, 2020
@hemanttanwar hemanttanwar changed the title API correction based on final review ServiceBus GA - API correction based on final review Nov 28, 2020
@hemanttanwar hemanttanwar merged commit 703acdb into Azure:master Nov 30, 2020
@hemanttanwar hemanttanwar deleted the sb-t2-api-correction-final-review branch November 30, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants