Remove resource filtering configuration #17682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moarychan
requested review from
backwind1233,
chenrujun,
jialindai,
kushagraThapar,
mbhaskar,
saragluna and
yiliuTo
as code owners
ghost
added
the
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
|
@mbhaskar and @kushagraThapar please help review. |
kushagraThapar
requested changes
Nov 20, 2020
| <directory>src/main/resources</directory> | ||
| <filtering>true</filtering> | ||
| <includes> | ||
| <include>META-INF/project.properties</include> |
There was a problem hiding this comment.
If the META-INF/project.properties was the only file that was being filtered out, then we should still have the spring.factories file shipped in the jar. So I am not sure if this would fix the issue or not.
Did we verify this locally, by creating a jar and making sure these files are now present in the jar ?
There was a problem hiding this comment.
@kushagraThapar are we okay to merge this PR now?
There was a problem hiding this comment.
@saragluna - yes this is good to go in now. Thanks for the reminder.
kushagraThapar
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed spring.factories file is not published:
#17651