Add HttpClientOptions #17582
Add HttpClientOptions #17582
Conversation
…hen using an HttpClientProvider to create an instance
alzimmermsft
added
Client
alzimmermsft
requested review from
anuchandy,
hemanttanwar,
jianghaolu and
srnagar
as code owners
| builder = builder.proxy(clientOptions.getProxyOptions()) | ||
| .configuration(clientOptions.getConfiguration()) | ||
| .writeTimeout(clientOptions.getWriteTimeout()) | ||
| .readTimeout(clientOptions.getReadTimeout()); |
There was a problem hiding this comment.
If I understand correctly ClientOptions::responseTimeout is not applicable for OkHttp right?
There was a problem hiding this comment.
Correct, OkHttp doesn't have an explicit API to set the timeout period for receiving a response for a request.
sdk/core/azure-core/src/main/java/com/azure/core/http/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
…ns to more locations, documentation updates
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| package com.azure.core.http; |
There was a problem hiding this comment.
How about moving the codesnippets into a package like com.azure.core.docs.*? This will keep the samples clean for the user to find runnable code samples.
There was a problem hiding this comment.
This sounds like a good location, let's do this in another PR.
Should we make this a standard convention? Ex. in AppConfiguration they'll use com.azure.data.appconfiguration.docs.*
There was a problem hiding this comment.
Yeah, this should be a standard convention for all client libraries.
sdk/core/azure-core/src/main/java/com/azure/core/util/HttpClientOptions.java
Outdated
Show resolved
Hide resolved
Fixes #10449
This PR introduces
HttpClientOptionsintoazure-core. The purpose of this class is to allow for general configuration ofHttpClients constructed usingHttpClientProvider. The options offered aren't a complete replacement of those allowed in each individualHttpClientbuilder class but a generalization of all common configurations available in outHttpClientbuilders.