mgmt compute support vm size enum generation #17476
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseeseesee
requested review from
ChenTanyi,
weidongxu-microsoft and
yungezz
as code owners
weidongxu-microsoft
approved these changes
Nov 11, 2020
|
Please take a note whether there is any sku type that get removed in this PR. |
ChenTanyi
approved these changes
Nov 11, 2020
|
Add to CHANGELOG |
|
|
||
| /** Defines values for VirtualMachineSizeTypes. */ | ||
| public final class VirtualMachineSizeTypes extends ExpandableStringEnum<VirtualMachineSizeTypes> { | ||
| TYPES_PLACE_HOLDER |
There was a problem hiding this comment.
This doesn't appear as if it would compile?
There was a problem hiding this comment.
It's placed under ../src/test/resources/.. as template file. We prepared one test method to pull all the values and generate/update the enum class by this template.
|
Close this as the spec PR changed. They plan to remove the enum data type on Dec 23rd, 2023 while now they add deprecate message instead of removing the enum values. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As compute service team mentioned before, they plan to remove the VM sizes from swagger spec. The recent spec PR shows they already start to work for this.
To avoid breaking change from SDK side, this PR could be potential solution to list resource skus and generate latest VM size enum type when it's required to update. After this got merged, I can open another one to revise the fixed value we applied to vm tests before.
Update:
The revapi reports below error
Actually the swagger is incorrect here.
The same issue already reported here, while the fix only applied to docs.